FreeBSD supports strtod_l, but using it requires #include <xlocale.h>. We have to add the missing include to the HAVE_STRTOF_L block to prevent implicit declaration. This problem is reported by a FreeBSD user on a mailing list: http://lists.freebsd.org/pipermail/freebsd-gnome/2015-April/032138.html A patch is also attached in the mailing list post: http://lists.freebsd.org/pipermail/freebsd-gnome/attachments/20150424/353a704b/attachment.c
Thanks for reporting. I sent Jakob's patch to the mailing list (with a related cleanup patch): http://thread.gmane.org/gmane.comp.audio.pulseaudio.general/23571
This patch still doesn't get reviewed after it was posted more than one month ago ...
I really hope this patch can be accepted. We have waited for 4 months for this trivial include fix.
Tanu's both patches pushed to master now.
Breaks compiling with musl as standard library, which has strtod_l but no xlocale.h.
Can you make a patch?
Created attachment 118635 [details] [review] Include xlocale.h only if __FreeBSD__ defined This should do: Musl doesn't come with a macro to identify itself, so check for the one FreeBSD offers.
(In reply to Andreas Reis from comment #7) > Created attachment 118635 [details] [review] [review] > Include xlocale.h only if __FreeBSD__ defined > > This should do: Musl doesn't come with a macro to identify itself, so check > for the one FreeBSD offers. Can you add a check for xlocale.h in configure.ac instead? xlocale.h is not a FreeBSD-specific header.
Created attachment 118644 [details] [review] Include xlocale.h only if existing
Attachment 118644 [details] works fine on FreeBSD.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.