Bug 90301 - rendercheck: print_tests uses *file/stderr inconsistently
Summary: rendercheck: print_tests uses *file/stderr inconsistently
Status: RESOLVED MOVED
Alias: None
Product: xorg
Classification: Unclassified
Component: App/other (show other bugs)
Version: git
Hardware: Other All
: medium normal
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-04 13:55 UTC by Chris Bainbridge
Modified: 2018-08-10 21:36 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments

Description Chris Bainbridge 2015-05-04 13:55:45 UTC
rendercheck seems to print to stdout, a file handle is passed to print_tests and then used for putc but not printf.

diff --git a/main.c b/main.c
index a7035b9..3b40dd6 100644
--- a/main.c
+++ b/main.c
@@ -134,12 +134,12 @@ void print_tests(FILE *file, int tests) {
             continue;
         if (j % 5 == 0) {
             if(j != 0)
-                putc('\n', stderr);
-            putc('\t', stderr);
+                putc('\n', file);
+            putc('\t', file);
         } else {
-            fprintf(stderr, ", ");
+            fprintf(file, ", ");
         }
-        fprintf(stderr, "%s", available_tests[i].name);
+        fprintf(file, "%s", available_tests[i].name);
         j++;
     }
     if (j)
Comment 1 Alan Coopersmith 2018-03-24 07:23:38 UTC
The file handle passed to print_tests is always stderr:
    print_tests(stderr, ~0);

so while changing this code may be correct, it also seems like it would have
no real effect.
Comment 2 GitLab Migration User 2018-08-10 21:36:11 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/xorg/test/rendercheck/issues/1.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.