Bug 90437 - unable to reinstall when host-tool is set
Summary: unable to reinstall when host-tool is set
Status: RESOLVED FIXED
Alias: None
Product: pkg-config
Classification: Unclassified
Component: src (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: pkg-config
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-13 14:35 UTC by Diab Jerius
Modified: 2015-06-13 16:57 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
build: Force linking of host tool (944 bytes, patch)
2015-06-13 16:55 UTC, Dan Nicholson
Details | Splinter Review

Description Diab Jerius 2015-05-13 14:35:57 UTC
When attempting to reinstall pkg-config 0.28 over an existing 0.28 install with host-tool enabled, the re-installation fails because the install-exec-hook recipe doesn't check if the link already exists.  To wit:

make install

Making install in .
make[1]: Entering directory '/data/macabretmp/dj/pkg-config-0.28'
make[2]: Entering directory '/data/macabretmp/dj/pkg-config-0.28'
 /bin/mkdir -p '/home/dj/tmp/gasdf/bin'
  /bin/bash ./libtool   --mode=install /usr/bin/install -c pkg-config '/home/dj/tmp/gasdf/bin'
libtool: install: /usr/bin/install -c pkg-config /home/dj/tmp/gasdf/bin/pkg-config
make  install-exec-hook
make[3]: Entering directory '/data/macabretmp/dj/pkg-config-0.28'
cd /home/dj/tmp/gasdf/bin && ln pkg-config x86_64-unknown-linux-gnu-pkg-config
ln: failed to create hard link `x86_64-unknown-linux-gnu-pkg-config': File exists
Makefile:1096: recipe for target 'install-exec-hook' failed
make[3]: *** [install-exec-hook] Error 1
make[3]: Leaving directory '/data/macabretmp/dj/pkg-config-0.28'
Makefile:1020: recipe for target 'install-exec-am' failed
make[2]: *** [install-exec-am] Error 2
make[2]: Leaving directory '/data/macabretmp/dj/pkg-config-0.28'
Makefile:963: recipe for target 'install-am' failed
make[1]: *** [install-am] Error 2
make[1]: Leaving directory '/data/macabretmp/dj/pkg-config-0.28'
Makefile:622: recipe for target 'install-recursive' failed
make: *** [install-recursive] Error 1


Presumably if the next version of pkg-config also has the host-tool option, this will cause upgrades to fail as well.

Thanks,

Diab
Comment 1 Dan Nicholson 2015-06-13 16:55:12 UTC
Created attachment 116477 [details] [review]
build: Force linking of host tool

In case a reinstall is being performed, ensure than an existing host
tool is overwritten.
Comment 2 Dan Nicholson 2015-06-13 16:57:49 UTC
Fixed in d377ee6b740373895cb67cdc14a98c0d71650e05.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.