Bug 90692 - Fix installing xinit script
Summary: Fix installing xinit script
Status: RESOLVED FIXED
Alias: None
Product: systemd
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: systemd-bugs
QA Contact: systemd-bugs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-28 03:21 UTC by tingping
Modified: 2016-06-07 10:52 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:


Attachments
Fix not installing xinit script (1.01 KB, patch)
2015-05-28 03:21 UTC, tingping
Details | Splinter Review

Description tingping 2015-05-28 03:21:53 UTC
Created attachment 116106 [details] [review]
Fix not installing xinit script

Trivial bug, for some reason the xinitrc script is inside a conditional for kdbus which is unrelated.
Comment 1 David Herrmann 2015-06-14 13:27:30 UTC
I'm not a big fan of making this official systemd ABI. To clarify, this script is currently used to make kdbus work with .busname units for .desktop files. It is a hack we use while testing and developing kdbus. However, it's nothing we want to ship on real systems (at least not without downstream discussion).

Background story here is that Xorg might run multiple times per user. However, `systemd --user` can only run once per user. Therefore, a systemd user unit cannot know to which Xorg server to connect. Our xinit-hack always pushes the address of the last-started Xorg server into systemd as environment, thus enabling units to access Xorg. However, this should not be the job of systemd (systemd should not have any X11 specific code at all).

Last but not least, `systemd --user` hasn't been finished nor integrated into any existing distributions. So this needs discussion with downstream to decide how the per-user systemd units get access to per-session data. Given that sessions map n:1 to users, it will always be a hack to make any session-data accessible to per-user units. The real fix would be to make Xorg run only once per user (preferably as unit). In this case, it can place its socket in /run/user/$uid/ and all units get implicit access to it.
Comment 2 Lennart Poettering 2016-06-07 10:52:30 UTC
Closing, as the kdbus thing is gone anyway from makefile.am


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.