Bug 90822 - logind: Add a udev rule to tag all DRM cards with master-of-seat
Summary: logind: Add a udev rule to tag all DRM cards with master-of-seat
Status: RESOLVED FIXED
Alias: None
Product: systemd
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: All All
: medium normal
Assignee: systemd-bugs
QA Contact: systemd-bugs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-06-02 14:51 UTC by Philip Withnall
Modified: 2015-06-04 15:25 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
logind: Add a udev rule to tag all DRM cards with master-of-seat (1.99 KB, patch)
2015-06-02 14:51 UTC, Philip Withnall
Details | Splinter Review

Description Philip Withnall 2015-06-02 14:51:40 UTC
Patch attached to add a generic rule to tag DRM cards as master-of-seat. Not entirely sure if this is the right place for the rule, or whether it should go in (for example) rules installed by VirtualBox itself (in the VirtualBox guest additions which install the vboxvideo driver).

See the commit message for a full explanation.
Comment 1 Philip Withnall 2015-06-02 14:51:42 UTC
Created attachment 116247 [details] [review]
logind: Add a udev rule to tag all DRM cards with master-of-seat

This is needed for generic DRM devices like the VirtualBox vboxvideo
driver, which exposes itself as a generic, ID-less DRM device at
/dev/dri/card0 (after applying this commit):
   $ udevadm info --query=all --path \
      /sys/devices/pci0000:00/0000:00:02.0/drm/card0
   P: /devices/pci0000:00/0000:00:02.0/drm/card0
   N: dri/card0
   E: DEVNAME=/dev/dri/card0
   E: DEVPATH=/devices/pci0000:00/0000:00:02.0/drm/card0
   E: DEVTYPE=drm_minor
   E: ID_FOR_SEAT=drm-pci-0000_00_02_0
   E: ID_PATH=pci-0000:00:02.0
   E: ID_PATH_TAG=pci-0000_00_02_0
   E: MAJOR=226
   E: MINOR=0
   E: SUBSYSTEM=drm
   E: TAGS=:master-of-seat:seat:uaccess:
   E: USEC_INITIALIZED=59893

Without this patch, the capabilities for a seat on a VirtualBox
installation of systemd v219 incorrectly show it as non-graphical, even
though I can type these commands from an xterm:
   $ loginctl show-seat seat0
   Id=seat0
   CanMultiSession=yes
   CanTTY=yes
   CanGraphical=no
   …
Comment 2 Philip Withnall 2015-06-04 15:25:44 UTC
Reviewed and applied in https://github.com/systemd/systemd/pull/57.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.