Bug 90893 - _tcp_sock_is_writable() should compare base sockets
Summary: _tcp_sock_is_writable() should compare base sockets
Alias: None
Product: nice
Classification: Unclassified
Component: General (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Olivier Crête
QA Contact:
Depends on:
Reported: 2015-06-08 06:11 UTC by Jakub Adam
Modified: 2015-06-26 14:10 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

socket: add nice_socket_get_base() (7.38 KB, patch)
2015-06-08 06:11 UTC, Jakub Adam
Details | Splinter Review
agent: compare base sockets in _tcp_sock_is_writable() (1.06 KB, patch)
2015-06-08 06:12 UTC, Jakub Adam
Details | Splinter Review

Description Jakub Adam 2015-06-08 06:11:26 UTC
Created attachment 116349 [details] [review]
socket: add nice_socket_get_base()

The argument passed into the callback is always a base (TCP/UDP) socket,
which can't be directly compared with local candidate's sockptr (may be
TURN, http, or other socket wrapping another one). Thus, we have to
first extract candidate's base socket.

Two patches are attached. The first adds nice_socket_get_base() to socket API, allowing to retrieve a pointer to base of a NiceSocket. The second uses this new function in _tcp_sock_is_writable() to fix the described problem.
Comment 1 Jakub Adam 2015-06-08 06:12:10 UTC
Created attachment 116350 [details] [review]
agent: compare base sockets in _tcp_sock_is_writable()
Comment 2 Philip Withnall 2015-06-26 14:10:35 UTC
Migrated to Phabricator: http://phabricator.freedesktop.org/T114

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.