Bug 90945 - wrong assert for BGRA surfaces in vpp
Summary: wrong assert for BGRA surfaces in vpp
Status: RESOLVED FIXED
Alias: None
Product: libva
Classification: Unclassified
Component: intel (show other bugs)
Version: unspecified
Hardware: x86-64 (AMD64) Linux (All)
: medium blocker
Assignee: haihao
QA Contact: Sean V Kelley
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-06-12 05:28 UTC by Rainer Hochecker
Modified: 2015-06-25 05:36 UTC (History)
3 users (show)

See Also:
i915 platform:
i915 features:

Attachments
Fix support of BGRA in GEN75 (980 bytes, patch)
2015-06-19 18:43 UTC, Peter Frühberger 		Details | Splinter Review
Don't assert on output and input v2 (1.42 KB, patch)
2015-06-24 08:20 UTC, Peter Frühberger 		Details | Splinter Review
Show Obsolete (1) View All

Description Rainer Hochecker 2015-06-12 05:28:26 UTC 
Interop Vaapi / EGL requires BGRA surfaces on vaapi side. driver asserts when this format is set: http://cgit.freedesktop.org/vaapi/intel-driver/tree/src/gen75_vpp_vebox.c#n1452

BGRA is supported: http://cgit.freedesktop.org/vaapi/intel-driver/commit/src/i965_drv_video.c?id=8d2077666fa71cda672e0f5476f9b91369398a6a
Comment 1 Peter Frühberger 2015-06-19 18:43:29 UTC 
Created attachment 116601 [details] [review]
Fix support of BGRA in GEN75

@Haihao for review please
Comment 2 haihao 2015-06-24 07:30:21 UTC 
As BGRA is also supported for input surface, could you remove the assert() for input BGRA surface too ?
Comment 3 Peter Frühberger 2015-06-24 07:51:13 UTC 
Yes, will do. Will post an updated patch this evening.
Comment 4 Peter Frühberger 2015-06-24 08:20:47 UTC 
Created attachment 116685 [details] [review]
Don't assert on output and input v2
Comment 5 haihao 2015-06-25 05:36:48 UTC 
Applied, thanks

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.