Bug 91014 - Piglit regression: spec/!OpenGL 1.2/texture-packed-formats
Summary: Piglit regression: spec/!OpenGL 1.2/texture-packed-formats
Status: RESOLVED MOVED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Drivers/Gallium/i915g (show other bugs)
Version: 10.6
Hardware: x86-64 (AMD64) Linux (All)
: medium major
Assignee: Default DRI bug account
QA Contact: Default DRI bug account
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-06-18 00:11 UTC by Brian Wilson
Modified: 2019-09-18 19:30 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:


Attachments

Description Brian Wilson 2015-06-18 00:11:46 UTC
Piglit test: spec/!OpenGL 1.2/texture-packed-formats

We are seeing this Piglit regression on pineview (chromebook, the only chrome platform in our stable still using X and tested with Piglit)

The version of Mesa that ChromeOS is currently using passes this test in piglit. It is based on the following commit plus an additional 34 patches:
    1291788 glsl: Generate unique names for each const array lowered to uniforms [Nov 2014-ish]

It fails in the following Mesa commit:
    c2a0600 i965: Don't set NirOptions for stages that will use the vec4 backend [May 2015-ish]

It also fails in this recent Mesa commit:
    1a6e4f46ed117b393e26aff326e5b05d4aea7fb0 (gallium: remove explicit values from PIPE_CAP_ enums) [~June 10, 2015]
Comment 1 Mark Janes 2015-06-20 01:06:10 UTC
I built and tested mesa=c2a0600 on g33.  The test provided the
following output, running against the latest drm with gbm back end:

----------------------------------------------------
    </testcase>
    <testcase classname="piglit.spec.!opengl 1_2" name="texture-packed-formats.g33m64" status="pass" time="0.146700143814">
      <system-out>/tmp/build_root/m64/lib/piglit/bin/texture-packed-formats -auto
</system-out>
      <system-err>i915: unsupported texture swizzle for format 6
i915: unsupported texture swizzle for format 6
i915: unsupported texture swizzle for format 5
i915: unsupported texture swizzle for format 5
i915: unsupported texture swizzle for format 131
i915: unsupported texture swizzle for format 131
i915: unsupported texture swizzle for format 6
i915: unsupported texture swizzle for format 6
i915: unsupported texture swizzle for format 5
i915: unsupported texture swizzle for format 5
i915: unsupported texture swizzle for format 131
i915: unsupported texture swizzle for format 131
</system-err>
    </testcase>
----------------------------------------------------

status="pass" differs from what was reported in the bug.

I can't bisect further if I can't repro.
Comment 2 Brian Wilson 2015-06-22 17:13:03 UTC
Version of Piglit being used:
http://cgit.freedesktop.org/piglit/commit/?id=1f39e07d44f7d78557d69c505168afb8eab913c6

Here's the error:
06/13 08:36:34.256 DEBUG|        base_utils:0239| [stdout] + Running test [spec/!OpenGL 1.2/texture-packed-formats] of expected runtime 0.0 sec: [bin/texture-packed-formats -au
to]
06/13 08:36:34.847 DEBUG|        base_utils:0239| [stdout] Unexpected GL Error for GL_RGBA
06/13 08:36:34.850 DEBUG|        base_utils:0239| [stdout] Unexpected GL Error for GL_RGBA2
06/13 08:36:34.852 DEBUG|        base_utils:0239| [stdout] Unexpected GL Error for GL_RGBA4
06/13 08:36:34.856 DEBUG|        base_utils:0239| [stdout] Unexpected GL Error for GL_RGB5_A1
06/13 08:36:34.866 DEBUG|        base_utils:0239| [stdout] Unexpected GL Error for GL_RGBA8
06/13 08:36:34.867 DEBUG|        base_utils:0239| [stdout] Unexpected GL Error for GL_RGBA12
06/13 08:36:34.868 DEBUG|        base_utils:0239| [stdout] Unexpected GL Error for GL_RGBA16
06/13 08:36:34.869 DEBUG|        base_utils:0239| [stdout] Unexpected GL Error for GL_RGB10_A2
06/13 08:36:34.871 DEBUG|        base_utils:0239| [stdout] Unexpected GL Error for GL_RGB
06/13 08:36:34.872 DEBUG|        base_utils:0239| [stdout] Unexpected GL Error for GL_R3_G3_B2
06/13 08:36:34.873 DEBUG|        base_utils:0239| [stdout] Unexpected GL Error for GL_RGB4
06/13 08:36:34.875 DEBUG|        base_utils:0239| [stdout] Unexpected GL Error for GL_RGB5
06/13 08:36:34.877 DEBUG|        base_utils:0239| [stdout] Unexpected GL Error for GL_RGB8
06/13 08:36:34.878 DEBUG|        base_utils:0239| [stdout] Unexpected GL Error for GL_RGB10
06/13 08:36:34.879 DEBUG|        base_utils:0239| [stdout] Unexpected GL Error for GL_RGB12
06/13 08:36:34.880 DEBUG|        base_utils:0239| [stdout] Unexpected GL Error for GL_RGB16
06/13 08:36:34.881 DEBUG|        base_utils:0239| [stdout] Unexpected GL Error for GL_RGBA
06/13 08:36:34.883 DEBUG|        base_utils:0239| [stdout] Unexpected GL Error for GL_RGBA2
06/13 08:36:34.884 DEBUG|        base_utils:0239| [stdout] Unexpected GL Error for GL_RGBA4
06/13 08:36:34.888 DEBUG|        base_utils:0239| [stdout] Unexpected GL Error for GL_RGB5_A1
06/13 08:36:34.890 DEBUG|        base_utils:0239| [stdout] Unexpected GL Error for GL_RGBA8
06/13 08:36:34.891 DEBUG|        base_utils:0239| [stdout] Unexpected GL Error for GL_RGBA12
06/13 08:36:34.892 DEBUG|        base_utils:0239| [stdout] Unexpected GL Error for GL_RGBA16
06/13 08:36:34.893 DEBUG|        base_utils:0239| [stdout] Unexpected GL Error for GL_RGB10_A2
06/13 08:36:34.895 DEBUG|        base_utils:0239| [stdout] Unexpected GL Error for GL_RGB
06/13 08:36:34.896 DEBUG|        base_utils:0239| [stdout] Unexpected GL Error for GL_R3_G3_B2
06/13 08:36:34.897 DEBUG|        base_utils:0239| [stdout] Unexpected GL Error for GL_RGB4
06/13 08:36:34.898 DEBUG|        base_utils:0239| [stdout] Unexpected GL Error for GL_RGB5
06/13 08:36:34.900 DEBUG|        base_utils:0239| [stdout] Unexpected GL Error for GL_RGB8
06/13 08:36:34.904 DEBUG|        base_utils:0239| [stdout] Unexpected GL Error for GL_RGB10
06/13 08:36:34.905 DEBUG|        base_utils:0239| [stdout] Unexpected GL Error for GL_RGB12
06/13 08:36:34.906 DEBUG|        base_utils:0239| [stdout] Unexpected GL Error for GL_RGB16
06/13 08:36:34.908 DEBUG|        base_utils:0239| [stdout] PIGLIT: {"result": "fail" }
06/13 08:36:34.909 DEBUG|        base_utils:0239| [stdout] + fail :: spec/!OpenGL 1.2/texture-packed-formats
Comment 3 Chad Versace 2015-06-22 18:18:13 UTC
Brian Wilson said:
> It fails in the following Mesa commit:
    > c2a0600 i965: Don't set NirOptions for stages that will use the vec4 backend [May 2015-ish]

Incorrect. The actual Mesa tree that Brian's team is validating is commit c1a0600 plus many patches. I've the pushed the full tree, patches included, to 

  git://github.com/chadversary/mesa refs/tags/chadv/cros-gerrit-262788-patched

Also, the Piglit being tested is the following commit plus a few incosequential patches.

  commit 4069bec62a8a99c44573395ea1597694eeee760f
  Author:     Marek Olšák <marek.olsak@amd.com>
  AuthorDate: Thu Apr 30 14:11:26 2015 +0200
  Commit:     Marek Olšák <marek.olsak@amd.com>
  CommitDate: Thu Apr 30 22:41:02 2015 +0200
  Subject: framework: use the correct executable for GLES parser tests

Building that Piglit against recent Mesa, however, produces an error at linktime. The fix requires backporting Piglit commit 845ba0e4dfb9372307f5d3032abdd0860e76731b.
Comment 4 Mark Janes 2015-06-22 19:15:08 UTC
I was able to reproduce this bug using the old versions of piglit and mesa

  piglit:  1f39e07d44f7d78557d69c505168afb8eab913c6
  mesa:    c2a0600

After updating piglit to the latest revision, the test passes.

Based on this information, I think it is safe to conclude that this
bug does not indicate a regression in mesa.  Instead, it is caused by
using an obsolete version of piglit.
Comment 5 GitLab Migration User 2019-09-18 19:30:55 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/mesa/mesa/issues/665.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.