Bug 91018 - conncheck: set writable callback to socket from TCP active connect
Summary: conncheck: set writable callback to socket from TCP active connect
Status: RESOLVED MOVED
Alias: None
Product: nice
Classification: Unclassified
Component: General (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Olivier Crête
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-06-18 07:49 UTC by Jakub Adam
Modified: 2015-06-26 14:15 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
conncheck: set writable callback to socket from TCP active connect (2.15 KB, patch)
2015-06-18 07:49 UTC, Jakub Adam
Details | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jakub Adam 2015-06-18 07:49:09 UTC
Created attachment 116573 [details] [review]
conncheck: set writable callback to socket from TCP active connect

A new socket created in nice_tcp_active_socket_connect() should have its
writable callback set, because it's possible for it to become a base
socket of a peer reflexive candidate, if some is discovered by
connection checks on that TCP active candidate.

Previously, when such prflx candidate became selected, without write_cb
on the socket the agent was never notified about it becoming writable
again after the socket's buffer got filled up. This caused the data flow
to hang permanently.
Comment 1 Philip Withnall 2015-06-26 14:15:19 UTC
Migrated to Phabricator: http://phabricator.freedesktop.org/T117


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.