Bug 91069 - libinput-0.18 missing stat include
Summary: libinput-0.18 missing stat include
Status: RESOLVED FIXED
Alias: None
Product: Wayland
Classification: Unclassified
Component: libinput (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Wayland bug list
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-06-23 09:39 UTC by Gilles Dartiguelongue
Modified: 2015-06-25 07:24 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:

Attachments
Add missing include for *stat (814 bytes, patch)
2015-06-23 09:39 UTC, Gilles Dartiguelongue 		Details | Splinter Review
Add missing include for *stat (868 bytes, patch)
2015-06-25 07:05 UTC, Gilles Dartiguelongue 		Details | Splinter Review
Show Obsolete (1) View All

Description Gilles Dartiguelongue 2015-06-23 09:39:00 UTC 
Created attachment 116668 [details] [review]
Add missing include for *stat

While preparing the update for Gentoo, QA check spew:

 * QA Notice: Package triggers severe warnings which indicate that it
 *            may exhibit random runtime failures.
 * path.c:303:2: warning: implicit declaration of function 'stat' [-Wimplicit-function-declaration]
 * evdev.c:1980:2: warning: implicit declaration of function 'fstat' [-Wimplicit-function-declaration]

 * Please do not file a Gentoo bug and instead report the above QA
 * issues directly to the upstream developers of this software.
 * Homepage: http://www.freedesktop.org/wiki/Software/libinput/

Attached patch fixes the issue.
Comment 1 Peter Hutterer 2015-06-24 09:36:06 UTC 
thanks. can I assume you signed-off-by for this patch?
Comment 2 Gilles Dartiguelongue 2015-06-25 07:03:18 UTC 
Sure
Comment 3 Gilles Dartiguelongue 2015-06-25 07:05:01 UTC 
Created attachment 116706 [details] [review]
Add missing include for *stat

Added signed-off-by.
Comment 4 Peter Hutterer 2015-06-25 07:09:44 UTC 
commit 387b8057b14ffcf2f953cbd9a86f0992efabef8c
Author: Gilles Dartiguelongue <eva@gentoo.org>
Date:   Tue Jun 23 11:31:56 2015 +0200

    Add missing includes for *stat
Comment 5 Gilles Dartiguelongue 2015-06-25 07:24:33 UTC 
Thanks.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.