Bug 91228 - `#pragma error` is not a valid pragma for MSVC
Summary: `#pragma error` is not a valid pragma for MSVC
Status: RESOLVED FIXED
Alias: None
Product: HarfBuzz
Classification: Unclassified
Component: src (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Behdad Esfahbod
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-04 19:22 UTC by Arnav Singh
Modified: 2015-07-05 21:44 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Arnav Singh 2015-07-04 19:22:53 UTC
Commit cdcdfe61b97a0a48ccf834b6d924d187da9609be changed two `#pragma message` to `#pragma error` in hb-unicode.cc, however MSVC uses #error, just like the #else branch. `#pragma error` is an unknown pragma so MSVC does not fail the build because of it, which I believe was the intention of that commit.

If it's meant to be an #error, then the #ifdef for _MSC_VER can be removed entirely.
Comment 1 Behdad Esfahbod 2015-07-05 21:44:40 UTC
Fixed.  Thanks.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.