Bug 9144 - Drop Mesa wrappers for XFree86
Summary: Drop Mesa wrappers for XFree86
Status: RESOLVED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Mesa core (show other bugs)
Version: git
Hardware: x86 (IA32) Linux (All)
: high trivial
Assignee: mesa-dev
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 6355
  Show dependency treegraph
 
Reported: 2006-11-23 22:42 UTC by George -
Modified: 2009-08-24 12:25 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
patch (16.82 KB, patch)
2006-11-23 22:43 UTC, George -
Details | Splinter Review

Description George - 2006-11-23 22:42:54 UTC
I think the libc wrapper was dropped in X.org 7.1 and it's unlikely that Mesa
HEAD builds against Xorg 7.0 anymore.

This leaves two appearances of XFree86LOADER:
./include/GL/internal/glcore.h
./src/mesa/main/context.c
Comment 1 George - 2006-11-23 22:43:30 UTC
Created attachment 7887 [details] [review]
patch
Comment 2 Brian Paul 2006-11-27 08:51:33 UTC
OK, I've fixed glcore.h and context.c
I'm going to leave the rest as-is until after the 6.5.2 release just to be safe.
Comment 3 George - 2006-12-20 22:21:24 UTC
Can I commit this now ?
Comment 4 Brian Paul 2006-12-21 08:09:20 UTC
Yes, go ahead.

I think the next step may be to deprecate some of _mesa_foobar() wrappers in
imports.[ch] entirely.
Comment 5 George - 2006-12-21 09:46:22 UTC
Committed.

Yeap, probably drop the math-related wrappers, but keep the mem- and file-related.
Comment 6 Brian Paul 2006-12-21 09:58:47 UTC
I was thinking just the opposite.

We need to be especially careful with math-related functions/macros.  Changes
can easily break conformance tests.

_mesa_memcpy(), on the other hand, could safely go away.
Comment 7 George - 2006-12-21 10:39:58 UTC
I was thinking of math functions that are simple wrappers and are likely to
appear in computation kernels. Yes, I guess memcpy is equally or more critical
but alloc/free seem useful.

Comment 8 Adam Jackson 2009-08-24 12:25:12 UTC
Mass version move, cvs -> git


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.