Bug 91479 - libqmi c++ compile compatibility
Summary: libqmi c++ compile compatibility
Status: RESOLVED FIXED
Alias: None
Product: libqmi
Classification: Unclassified
Component: libqmi (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Dan Williams
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-27 21:24 UTC by Matt
Modified: 2015-08-02 07:30 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
possible fix (523 bytes, text/plain)
2015-07-27 21:24 UTC, Matt
Details

Description Matt 2015-07-27 21:24:08 UTC
Created attachment 117407 [details]
possible fix

Attached patch fixes a C++ compile issue with auto-generated code (qmi-dms.h) that has a variable named "new" in a function prototype.

I believe I missed another spot where a change is required to make the documentation update correctly.
Comment 1 Matt 2015-07-27 21:24:26 UTC
version 1.12.6
Comment 2 Aleksander Morgado 2015-08-02 07:30:03 UTC
(In reply to Matt from comment #0)
> Created attachment 117407 [details]
> possible fix
> 
> Attached patch fixes a C++ compile issue with auto-generated code
> (qmi-dms.h) that has a variable named "new" in a function prototype.
> 
> I believe I missed another spot where a change is required to make the
> documentation update correctly.

I fixed it in some other way; instead of renaming the variable, which would change the getter method, I forced the variables to be generated with some other name while keeping the method name the same, see:

http://cgit.freedesktop.org/libqmi/commit/?id=a3cfd87ac31b2901f0aad4c8522aadf901828d4b

Thanks for the report!


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.