Bug 91484 - duplicate enum SpiceImageCompress and spice_image_compression_t
Summary: duplicate enum SpiceImageCompress and spice_image_compression_t
Status: RESOLVED FIXED
Alias: None
Product: Spice
Classification: Unclassified
Component: server (show other bugs)
Version: unspecified
Hardware: All All
: medium minor
Assignee: Spice Bug List
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-28 09:50 UTC by db
Modified: 2015-07-28 11:51 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments

Description db 2015-07-28 09:50:02 UTC 
SPICE_IMAGE_COMPRESS_* are defined twice.

spice-protocol: ./spice/enums.h:184
spice-server: ./spice.h:474

I think it sould be removed from the spice-server code.
Comment 1 Christophe Fergeau 2015-07-28 11:33:12 UTC 
This is being fixed upstream, and a new spice-protocol should follow shortly.
Comment 2 db 2015-07-28 11:45:06 UTC 
it is fixed by a94836a467a942f32ed5cc88d2941101c995f355 in the spice server repo.

sorry that I did not check the current development branch.
Comment 3 db 2015-07-28 11:50:44 UTC 
(In reply to db from comment #2)
> it is fixed by a94836a467a942f32ed5cc88d2941101c995f355 in the spice server
> repo.
> 
> sorry that I did not check the current development branch.

sry wrong commit hash. it is: 22c40b9d1fadc7892580aeb831514a81320e7b76
Comment 4 Christophe Fergeau 2015-07-28 11:51:46 UTC 
That fix is only partial as newer spice-protocol releases should not break build of older spice-server releases, this is what a new spice-protocol release will try to fix.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.