Bug 91642 - legacy codepages entries not generated for raster fonts
Summary: legacy codepages entries not generated for raster fonts
Status: RESOLVED MOVED
Alias: None
Product: xorg
Classification: Unclassified
Component: App/mkfont* (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-08-15 07:02 UTC by Yury
Modified: 2018-08-10 20:37 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
patch of my changes against the 1.1.1 source (951 bytes, patch)
2015-08-15 07:03 UTC, Yury
no flags Details | Splinter Review

Description Yury 2015-08-15 07:02:52 UTC
I've noticed recently that mkfontscale version 1.1.1 (1.1.2, too) is not generating legacy codepages entries for raster fonts, when -a switch is used. No amount of 'fuzziness allowed' helps (-f switch).

Looking into the source reveals that 1) `reencodeLegacy` variable is likely used incorrectly -- semantically opposite of what would be expected after reading the manpage, and 2) `failed` variable is used in too strict a manner, not allowing for ANY fuzziness at all. Anyway, that was my opinion after looking.

I've made the straightforward changes in the source, and now it seems the problems are gone (patch attached).
Comment 1 Yury 2015-08-15 07:03:52 UTC
Created attachment 117700 [details] [review]
patch of my changes against the 1.1.1 source
Comment 2 GitLab Migration User 2018-08-10 20:37:30 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/xorg/app/mkfontscale/issues/3.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.