Created attachment 117993 [details] [review]
Make application/x-sms-rom rules more precise

Created attachment 117994 [details] [review]
Add application/x-sg1000-rom

Created attachment 117995 [details] [review]
Add application/x-gamegear-rom

Created attachment 117999 [details] [review]
Make application/x-sms-rom rules more precise

Created attachment 118000 [details] [review]
Add application/x-sg1000-rom

Created attachment 118001 [details] [review]
Add application/x-gamegear-rom

Comment on attachment 117999 [details] [review]
Make application/x-sms-rom rules more precise

Review of attachment 117999 [details] [review]:
-----------------------------------------------------------------

::: tests/list
@@ +430,5 @@
>  disk.raw-disk-image.xz application/x-raw-disk-image-xz-compressed oxo
>  
>  # Video game ROMs
> +# Sonic the Hedgehog truncated to 1Ko
> +sms-test.sms application/x-sms-rom ox

why does it fail? File not big enough?

Comment on attachment 118000 [details] [review]
Add application/x-sg1000-rom

Review of attachment 118000 [details] [review]:
-----------------------------------------------------------------

::: freedesktop.org.xml.in
@@ +3289,5 @@
>      <_comment>Stampede package</_comment>
>      <generic-icon name="package-x-generic"/>
>    </mime-type>
> +  <mime-type type="application/x-sg1000-rom">
> +    <_comment>SG-1000 ROM</_comment>

Missing <acronym> and <expanded-acronym>

@@ +3291,5 @@
>    </mime-type>
> +  <mime-type type="application/x-sg1000-rom">
> +    <_comment>SG-1000 ROM</_comment>
> +    <generic-icon name="application-x-executable"/>
> +    <glob pattern="*.sg"/>

No magic?

Comment on attachment 118001 [details] [review]
Add application/x-gamegear-rom

Review of attachment 118001 [details] [review]:
-----------------------------------------------------------------

::: freedesktop.org.xml.in
@@ +3309,5 @@
>    </mime-type>
> +  <mime-type type="application/x-gamegear-rom">
> +    <_comment>Game Gear ROM</_comment>
> +    <generic-icon name="application-x-executable"/>
> +    <!-- Disabled, the magic would be too far into the file

Same problem with the sms magic, no?

(In reply to Bastien Nocera from comment #7)
> Comment on attachment 117999 [details] [review] [review]
> Make application/x-sms-rom rules more precise
> 
> Review of attachment 117999 [details] [review] [review]:
> -----------------------------------------------------------------
> 
> ::: tests/list
> @@ +430,5 @@
> >  disk.raw-disk-image.xz application/x-raw-disk-image-xz-compressed oxo
> >  
> >  # Video game ROMs
> > +# Sonic the Hedgehog truncated to 1Ko
> > +sms-test.sms application/x-sms-rom ox
> 
> why does it fail? File not big enough?

Oh, disabled because the magic is too far...

Comment on attachment 118001 [details] [review]
Add application/x-gamegear-rom

Review of attachment 118001 [details] [review]:
-----------------------------------------------------------------

::: freedesktop.org.xml.in
@@ +3309,5 @@
>    </mime-type>
> +  <mime-type type="application/x-gamegear-rom">
> +    <_comment>Game Gear ROM</_comment>
> +    <generic-icon name="application-x-executable"/>
> +    <!-- Disabled, the magic would be too far into the file

Yes, both have this problem.

I still completed the magic for both in case it is enabled again, so we can tell the ones from the others.

Created attachment 125483 [details] [review]
Make application/x-sms-rom rules more precise

Check a byte to know if it actually is a Master System ROM.

Also remove the *.sg and *.gg glob patterns which are for the
application/x-sg1000-rom and application/x-gamegear-rom types which will
be added in next commits.

Created attachment 125484 [details] [review]
Add application/x-sg1000-rom

Created attachment 125485 [details] [review]
Add application/x-gamegear-rom

Attachment 125483 [details] pushed as 97f2cde - Make application/x-sms-rom rules more precise
Attachment 125484 [details] pushed as e782480 - Add application/x-sg1000-rom
Attachment 125485 [details] pushed as 14b348f - Add application/x-gamegear-rom