Bug 91818 - Right-click generated by tap-and-hold
Summary: Right-click generated by tap-and-hold
Status: RESOLVED FIXED
Alias: None
Product: Wayland
Classification: Unclassified
Component: libinput (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Wayland bug list
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-31 00:08 UTC by Peter Hutterer
Modified: 2015-09-07 00:48 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments

Description Peter Hutterer 2015-08-31 00:08:49 UTC
From https://bugzilla.redhat.com/show_bug.cgi?id=1256045

Finger order:
first finger down
second finger down
first finger up
second finger held down

This generates a right-click tap event. In the original bug report the main issue is that this interferes with scroll events. Even without that, a tap with a finger held down should generate a left-click event, not a right click event.

Possible solution is adding another timeout state to the current transition from TAP_2 so that the right button event is only generated when the second finger is also released within the timeout. Otherwise, we can move to the multitap states or swallow the button event altogether.

Notably, this also requires us to keep track of which finger was released, since putting first finger down, tapping with the second finger and then keeping the first finger down is a definitive tap.
Comment 1 Peter Hutterer 2015-09-07 00:48:02 UTC
commit 79570fd492691b4ce97360e7775965e5765a702b
Author: Peter Hutterer <peter.hutterer@who-t.net>
Date:   Mon Aug 31 11:10:58 2015 +1000

    touchpad: don't tap for 2fg down, followed by a single finger up


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.