Bug 91838 - RFE: use domains during logging in spice-gtk
Summary: RFE: use domains during logging in spice-gtk
Status: RESOLVED MOVED
Alias: None
Product: Spice
Classification: Unclassified
Component: spice-gtk (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Victor Toso
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-01 14:34 UTC by David Jaša
Modified: 2018-06-03 10:20 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments

Description David Jaša 2015-09-01 14:34:31 UTC
When debugging e.g. network issues, it's quite inconvenient to create a good grep pattern to filter out keyboard, display, streaming, ... messages. It would be nice for spice-gtk to assign a functionality domain for debug messages and make it possible to specify what domains are to be printed.
Comment 1 Marc-Andre Lureau 2015-09-01 14:38:03 UTC
what do you mean by domain?

you have already plenty of domain by filtering by filename for example.

Furthermore, when the message is channel specific, you have the channel name.

What else do you need?
Comment 2 Victor Toso 2015-09-01 14:44:58 UTC
(In reply to Marc-Andre Lureau from comment #1)
> what do you mean by domain?
> 
> you have already plenty of domain by filtering by filename for example.
> 
> Furthermore, when the message is channel specific, you have the channel name.
> 
> What else do you need?

Well, I particulary like filtering debug domain and level by env var such as we do in Grilo [0]

[0] https://developer.gnome.org/grilo/unstable/ch02.html#debugging-with-grilo

That's not much work to implement on spice-gtk, I think.
Comment 3 Victor Toso 2016-01-08 09:38:57 UTC
wip in mailing list
http://lists.freedesktop.org/archives/spice-devel/2016-January/025293.html
Comment 4 Victor Toso 2016-01-18 15:44:04 UTC
Hi David,

Could give some feedback regarding the proposal for this RFE? Comment #3 has the link!

So far, opinions are that it is complicated and most likely not necessary. I plan to address a few issues and also make spice-server to use this as well (so one could actually see the full picture of this...)

If people don't think it is useful then this bug would probably be closed in near future.
Comment 5 Victor Toso 2016-03-12 14:47:33 UTC
(In reply to Victor Toso from comment #4)
> Hi David,
> 
> Could give some feedback regarding the proposal for this RFE? Comment #3 has
> the link!

v3 at https://lists.freedesktop.org/archives/spice-devel/2016-March/027279.html
Comment 6 Victor Toso 2016-05-04 10:06:00 UTC
This is on hold till we get better support in glib for it.

https://bugzilla.gnome.org/show_bug.cgi?id=744456
Comment 7 Victor Toso 2016-07-29 23:35:41 UTC
(In reply to Victor Toso from comment #6)
> This is on hold till we get better support in glib for it.
> 
> https://bugzilla.gnome.org/show_bug.cgi?id=744456

For glib 2.50 it seems!

https://developer.gnome.org/glib/2.49/glib-Message-Logging.html#g-log-structured
Comment 8 GitLab Migration User 2018-06-03 10:20:22 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/spice/spice-gtk/issues/10.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.