Bug 91859 - Assignment instead of check for equality in assert: asyncns_setuserdata, asyncns_getuserdata
Summary: Assignment instead of check for equality in assert: asyncns_setuserdata, asyn...
Status: NEW
Alias: None
Product: libasyncns
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: All All
: medium trivial
Assignee: Lennart Poettering
QA Contact: Lennart Poettering
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-03 08:09 UTC by Olof Sivertsson
Modified: 2015-09-03 08:09 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments

Description Olof Sivertsson 2015-09-03 08:09:46 UTC 
Bug applies to libasyncns release 0.8 and current git revision 68cd5a.

Both asyncns_setuserdata(...) and asyncns_getuserdata(...) contain the following line:

  assert(q->asyncns = asyncns);


I believe this should not be assignment, but a check for equality, as is correctly done already in asyncns_isdone(...):

  assert(q->asyncns == asyncns);


Thank you for a very useful and fine piece of free software in libasyncns!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.