Bug 91916 - [All bisected] Render error when running Unigine-Heave_v4.0
Summary: [All bisected] Render error when running Unigine-Heave_v4.0
Status: CLOSED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Drivers/DRI/i965 (show other bugs)
Version: unspecified
Hardware: Other All
: high major
Assignee: Ian Romanick
QA Contact: Intel 3D Bugs Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-08 06:39 UTC by wendy.wang
Modified: 2015-09-23 08:33 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:


Attachments
error pic (1.27 MB, text/plain)
2015-09-08 06:39 UTC, wendy.wang
Details
xorg.log (17.04 KB, text/plain)
2015-09-08 06:39 UTC, wendy.wang
Details
error pic (1.27 MB, image/png)
2015-09-08 06:42 UTC, wendy.wang
Details
error picture re-unload (1.27 MB, image/png)
2015-09-08 06:43 UTC, wendy.wang
Details

Description wendy.wang 2015-09-08 06:39:19 UTC
Created attachment 118135 [details]
error pic

System Environment:
--------------------------
Mesa Regression: yes
Failed Platform: IVB/BYT/HSW/BDW/BSW/SKL

Bug detailed description:
-----------------------------
Render error with black pictures when running Unigine-Heave_v4.0
pls refer to attached error picture and xorg.log

Good gfx sw driver stack on July 22:
Libdrm:         (master)libdrm-2.4.62-10-g293f8fac0a5c1cfd825005c94329aa8a5cd5ce30
 Mesa:          (master)fcc1949cc4d97d8ed714020d5b86b31b70eca774
 Xserver:               (master)xorg-server-1.17.0-284-ga8a0f6464a33c12c1de495d74fd478c0d952643e
 Xf86_video_intel:              (master)2.99.917-385-g7301516b63d2e5fcd594f1e50a0f7b3b9bb5cadb
 Cairo:         (master)2cf2d8e340a325adb205baf8e4bd64e1d1858008    

Bad gfx sw driver stack on July 24
Libdrm:		(master)libdrm-2.4.62-10-g293f8fac0a5c1cfd825005c94329aa8a5cd5ce30
 Mesa:		(master)30f97b5e52b324d501c56df8902d294fb755a5b7
 Xserver:		(master)xorg-server-1.17.0-284-ga8a0f6464a33c12c1de495d74fd478c0d952643e
 Xf86_video_intel:		(master)2.99.917-388-g2050d03f520a5027450b65c2617ab02a92287d23
 Cairo:		(master)2cf2d8e340a325adb205baf8e4bd64e1d1858008
 

Reproduce steps:
---------------------------
1.  xinit& 
2.  gnome-session&
3. cd unigine-heaven-1.5.2/Unigine_Heaven-4.0/
4. export LD_LIBRARY_PATH=bin/:$LD_LIBRARY_PATH 
5. export force_glsl_extensions_warn=true export MESA_EXTENSION_OVERRIDE="-GL_ARB_sample_shading"
6. vblank_mode=0 ./bin/heaven_x64 -video_app opengl -data_path ../ -sound_app null -engine_config ../data/heaven_4.0.cfg -system_script heaven/unigine.cpp -video_mode -1 -video_fullscreen 1 -extern_define PHORONIX,RELEASE -video_width 1920 -video_height 1080
Comment 1 wendy.wang 2015-09-08 06:39:49 UTC
Created attachment 118136 [details]
xorg.log
Comment 2 wendy.wang 2015-09-08 06:42:02 UTC
Created attachment 118137 [details]
error pic
Comment 3 wendy.wang 2015-09-08 06:43:11 UTC
Created attachment 118138 [details]
error picture re-unload
Comment 4 ye.tian 2015-09-08 07:44:08 UTC
By bisect, shows the first bad mesa commit is 5ead4487.

commit 5e3974338ed7ea49a41405f8c2e4bcd5fd1f5c80
Author:     Marek Olšák <marek.olsak@amd.com>
AuthorDate: Thu Jul 16 14:54:50 2015 +0200
Commit:     Marek Olšák <marek.olsak@amd.com>
CommitDate: Thu Jul 23 00:59:24 2015 +0200

    gallium/radeon: remove buffer_unmap calls that can potentially decrease perf

    buffer_unmap is currently a no-op on radeon and done correctly on amdgpu.
    I plan to fix it for radeon, but before that, all occurences of buffer_unmap
    that can negatively affect performance in the future must be removed.

    There are 2 reasons for removing buffer_unmap calls:
    - There is a likelihood that buffer_map will be called again, so we don't
      want to unmap yet.
    - The buffer is being released, which automatically unmaps it.

    Reviewed-by: Michel Dänzer <michel.daenzer@amd.com>
Comment 5 Matt Turner 2015-09-08 14:50:06 UTC
That bisection must be wrong, since the commit is to the Radeon driver.

Two commits later, however, is

commit 5ead448719f39d27bfbf4cabf138324dfee34a4f
Author: Marek Olšák <marek.olsak@amd.com>
Date:   Tue Jun 16 22:13:34 2015 +0200

    drirc: drop support for Heaven 3.0, fixes tessellation in 4.0

which seems like something worth retesting.
Comment 6 ye.tian 2015-09-09 02:11:39 UTC
(In reply to Matt Turner from comment #5)
> That bisection must be wrong, since the commit is to the Radeon driver.
> 
> Two commits later, however, is
> 
> commit 5ead448719f39d27bfbf4cabf138324dfee34a4f
> Author: Marek Olšák <marek.olsak@amd.com>
> Date:   Tue Jun 16 22:13:34 2015 +0200
> 
>     drirc: drop support for Heaven 3.0, fixes tessellation in 4.0
> 
> which seems like something worth retesting.


Yes, the bisection commit is wrong.
The first bad commit is 5ead448, Its parents commit 6b37643 is good.
Comment 7 Ian Romanick 2015-09-09 02:35:12 UTC
I think you'll need to update to Heaven 4.0.  Can you try that and let us know if it works?
Comment 8 Matt Turner 2015-09-09 02:51:46 UTC
Well, the report says they are using 4.0. Maybe some of the workarounds were actually applicable to 4.0?
Comment 9 ye.tian 2015-09-09 03:07:19 UTC
Our Heaven version is Unigine_Heaven-4.0.run. But I am not sure that is the latest version.
Comment 10 Eero Tamminen 2015-09-09 07:22:29 UTC
(In reply to Matt Turner from comment #8)
> Well, the report says they are using 4.0. Maybe some of the workarounds were
> actually applicable to 4.0?

Looking at info in QA wiki, Heaven v4 is run with;
  export force_glsl_extensions_warn=true
  export MESA_EXTENSION_OVERRIDE="-GL_ARB_sample_shading"
  ./bin/heaven_x64 ... -extern_define PHORONIX,RELEASE

And this is what's removed from the drirc by the commit:
-            <option name="force_glsl_extensions_warn" value="true" />
-            <option name="disable_blend_func_extended" value="true" />
-            <option name="force_glsl_version" value="130" />
-            <option name="disable_shader_bit_encoding" value="true" />


As the commit mentions tessalation, and I've always run Heaven with:
-extern_define ,BENCHMARK,RELEASE,LANGUAGE_EN,QUALITY_HIGH,TESSELLATION_DISABLED

I wonder would TESSALATION_DISABLED option for Heaven change anything?
Comment 11 Eero Tamminen 2015-09-09 07:24:51 UTC
Sorry, looking at the attached error pic, it's not tessalation but fragment shading issue.

Wendy/Ye, you get error message(s) from Mesa shader compiler when you run Heaven.  Please paste them to the bug.
Comment 12 Marek Olšák 2015-09-09 10:46:53 UTC
(In reply to Eero Tamminen from comment #10)
> (In reply to Matt Turner from comment #8)
> > Well, the report says they are using 4.0. Maybe some of the workarounds were
> > actually applicable to 4.0?
> 
> Looking at info in QA wiki, Heaven v4 is run with;
>   export force_glsl_extensions_warn=true
>   export MESA_EXTENSION_OVERRIDE="-GL_ARB_sample_shading"
>   ./bin/heaven_x64 ... -extern_define PHORONIX,RELEASE

Can you remove all environment variables affecting it? Having drirc installed should be enough.
Comment 13 wendy.wang 2015-09-23 08:33:13 UTC
This issue has been fixed using latest GFX SW stack, so close this bug as fixed.
 Libdrm:		(master)libdrm-2.4.65-3-g14968e4cf63d16f5beaea5eb8edba7578bb90501
 Mesa:		(master)99b1f4751f97631011b64fabcb57acf6beae01ac
 Xserver:		(master)xorg-server-1.17.99.901-8-g58d54ee82dfae5486bc09d04d2760c922d54d631
 Xf86_video_intel:		(master)2.99.917-470-g7be6263b8207b7b7c4a00acf8e2335b345d3fda7
 Cairo:		(master)2cf2d8e340a325adb205baf8e4bd64e1d1858008


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.