Bug 91989 - Add support for multi-word $BROWSER commands
Summary: Add support for multi-word $BROWSER commands
Status: RESOLVED FIXED
Alias: None
Product: Portland
Classification: Unclassified
Component: xdg-utils (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Portland Bugs
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-13 07:50 UTC by Per Olofsson
Modified: 2015-09-16 15:05 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments
xdg-open-browser-multiword.diff (475 bytes, text/plain)
2015-09-13 07:50 UTC, Per Olofsson 		Details
xdg-open-browser-multiword-2.diff (537 bytes, patch)
2015-09-13 07:56 UTC, Per Olofsson 		Details | Splinter Review
Show Obsolete (1) View All

Description Per Olofsson 2015-09-13 07:50:32 UTC 
Created attachment 118230 [details]
xdg-open-browser-multiword.diff

If xdg-open falls back to using the $BROWSER variable, it does not support multi-word browser commands since IFS has been set to ':'. This patch fixes the issue by resetting IFS.
Comment 1 Per Olofsson 2015-09-13 07:56:31 UTC 
Created attachment 118231 [details] [review]
xdg-open-browser-multiword-2.diff

Here's a better version of the patch that uses a local variable instead of a global one to store the original IFS.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.