Bug 92088 - vaapi/intel-driver: properly set VAImage format in vaDeriveImage
Summary: vaapi/intel-driver: properly set VAImage format in vaDeriveImage
Status: RESOLVED FIXED
Alias: None
Product: libva
Classification: Unclassified
Component: intel (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: haihao
QA Contact: Sean V Kelley
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-23 09:45 UTC by Julien Isorce
Modified: 2015-10-20 00:35 UTC (History)
3 users (show)

See Also:
i915 platform:
i915 features:

Attachments
This patch allows to make gstvaapipostproc outputs RGBx and BGRx. (by extending the caps) (1.49 KB, patch)
2015-09-23 09:46 UTC, Julien Isorce 		Details | Splinter Review
Show Obsolete (1) View All

Description Julien Isorce 2015-09-23 09:45:09 UTC 
I found that in VaDeriveImage not all fields of VAImageFormat are set. Only fourcc. Also bits_per_pixel field is always set to 12 even for RGBx.

Patch follows
Comment 1 Julien Isorce 2015-09-23 09:46:41 UTC 
Created attachment 118409 [details] [review]
This patch allows to make gstvaapipostproc outputs RGBx and BGRx. (by extending the caps)
Comment 2 sreerenj 2015-09-23 10:42:54 UTC 
(In reply to Julien Isorce from comment #1)
> Created attachment 118409 [details] [review] [review]
> This patch allows to make gstvaapipostproc outputs RGBx and BGRx. (by
> extending the caps)

libva/libva-intel-driver usually accept patches from mailing list.
Would be good if you can do a git send-email to libva@lists.freedesktop.org
Comment 3 Julien Isorce 2015-09-28 22:08:04 UTC 
(In reply to sreerenj from comment #2)
> Would be good if you can do a git send-email to libva@lists.freedesktop.org
Done. I also sent an other patch for vaBeginPicture.
Comment 4 Julien Isorce 2015-10-11 15:15:13 UTC 
Comment on attachment 118409 [details] [review]
This patch allows to make gstvaapipostproc outputs RGBx and BGRx. (by extending the caps)

v2 submitted on mailing list
Comment 5 haihao 2015-10-20 00:35:59 UTC 
commit 4640d06a8ccb0a12e91bbd00cc3e2423d17ee243
Author: Julien Isorce <julien.isorce@gmail.com>
Date:   Tue Oct 13 09:10:46 2015 +0100

    vaDeriveImage: properly set VAImage format

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.