Bug 92161 - Dereference pointer after NULL check passed
Summary: Dereference pointer after NULL check passed
Status: RESOLVED MOVED
Alias: None
Product: xorg
Classification: Unclassified
Component: Lib/Xlib (show other bugs)
Version: unspecified
Hardware: x86 (IA32) Linux (All)
: medium normal
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-28 10:22 UTC by Bhavi Dhingra
Modified: 2018-08-10 20:11 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
Modifying the NULL check (518 bytes, text/plain)
2015-09-28 10:22 UTC, Bhavi Dhingra 		no flags Details
View All

Description Bhavi Dhingra 2015-09-28 10:22:14 UTC 
Created attachment 118483 [details]
Modifying the NULL check

In libX11/modules/om/generic/omTextEsc.c, Line #172,
Comparing fd to null implies that fd might be NULL,
At Line #175, dereferencing NULL pointer fd.

Modifying the NULL check, to avoid crash.
Comment 1 Bhavi Dhingra 2015-10-09 09:20:25 UTC 
Gentle reminder to resolve this bug with the attached patch.
Thank You
Comment 2 Olivier Fourdan 2015-10-09 09:34:03 UTC 
Best IMHO would be to send this patch as a "git format-patch" against current libX11 master with appropriate "Signed-off-by" to the xorg-devel mailing list for review.

This way it will show up in patchwork and has more chances to land in git.
Comment 3 GitLab Migration User 2018-08-10 20:11:10 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/xorg/lib/libx11/issues/47.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.