Bug 9224 - does not restore console
Summary: does not restore console
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/Radeon (show other bugs)
Version: git
Hardware: x86 (IA32) Linux (All)
: high normal
Assignee: xf86-video-ati maintainers
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-12-02 02:32 UTC by Michal Suchanek
Modified: 2007-01-07 09:35 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
Log of first xserver run (95.57 KB, text/plain)
2006-12-06 18:11 UTC, Eamon Walsh
no flags Details
Log of second xserver run (15.64 KB, text/plain)
2006-12-06 18:12 UTC, Eamon Walsh
no flags Details
configuration file (3.01 KB, text/plain)
2006-12-06 18:12 UTC, Eamon Walsh
no flags Details
log of running X server when switching is already broken (52.43 KB, text/plain)
2006-12-07 10:14 UTC, Michal Suchanek
no flags Details

Description Michal Suchanek 2006-12-02 02:32:04 UTC
With the new X server my text console is no longer restored.
Both terminating the X server and swiching to another vt leaves just blank screen.

I noticed that X -configure prints the card type on screen, and so does the X
server on startup. Is this done in graphics?

The same radeon driver with a 7.1 X server worked.

X Window System Version 7.1.99.2
Release Date: 21 December 2005
X Protocol Version 11, Revision 0, Release 7.1.99.2
Build Operating System: UNKNOWN 
Current Operating System: Linux fridge 2.6.182-src #5 Wed Nov 8 20:47:17 CET
2006 i686
Comment 1 Michal Suchanek 2006-12-06 03:30:28 UTC
I found that the X server does restore the console - sometimes.

I do not see any pattern in it. It just sometimes breaks. However, once broken
the console does not come back.
Comment 2 Eamon Walsh 2006-12-06 18:10:39 UTC
Not sure if my problem is identical but I am seeing a very similar regression in
master.  Exiting the server does not return to the console command prompt but
instead gives a blank screen with blinking cursor that does not respond to
Ctrl+Alt+F1.

What's worse is that running a second server does not work.  Some teardown is
not being performed properly.  I have attached both log files, the first server
(which runs but doesn't exit properly as described above) and the second server
(which won't run) as well as xorg.conf.

Using git-bisect I narrowed it down to the following commit: a6381e69....:
xfree86 DDX: Delete DDX screens in ddxGiveUp().  I can confirm that this change
introduces the bug; removing the three lines from xf86Init.c solves the problem
for me.

My hardware an is IBM ThinkPad T60p with a recent Radeon card running FC5. 
Video driver is VESA, standard keyboard & mouse drivers.
Comment 3 Eamon Walsh 2006-12-06 18:11:41 UTC
Created attachment 7992 [details]
Log of first xserver run
Comment 4 Eamon Walsh 2006-12-06 18:12:18 UTC
Created attachment 7993 [details]
Log of second xserver run
Comment 5 Eamon Walsh 2006-12-06 18:12:46 UTC
Created attachment 7994 [details]
configuration file
Comment 6 Michel Dänzer 2006-12-07 03:19:37 UTC
(In reply to comment #2)
> Not sure if my problem is identical 

I rather doubt it, as the regression you found shouldn't affect VT switching. I
suspect the original problem is driver specific, so please attach a full log
file Michal.


> What's worse is that running a second server does not work.  Some teardown is
> not being performed properly.

Ironically, the purpose of the change that caused the regression was to enable
teardown that wasn't done before... looks like that indeed does more than
expected, putting the graphics card into a bad state. I may look into this
later, but I just reverted the change for now.
Comment 7 Michal Suchanek 2006-12-07 10:14:07 UTC
Created attachment 8004 [details]
log of running X server when switching is already broken
Comment 8 Michel Dänzer 2006-12-08 02:06:19 UTC
(In reply to comment #0)
> I noticed that X -configure prints the card type on screen, and so does the X
> server on startup. Is this done in graphics?

No, sounds like the video BIOS POST output.

> The same radeon driver with a 7.1 X server worked.

Did you rebuild the driver against the server in both cases? As you seem to be
running the driver from git, can you check whether this also happens with the
latest release?
Comment 9 Michal Suchanek 2006-12-08 09:20:25 UTC
I recompiled the driver for the server afaict.

I do not use the 7.1 xorg release because OpenGL does not work on Radeon with that.

But I might be able to recompile the old driver and see if it fails to restore
console as well.
Comment 10 Michal Suchanek 2006-12-13 05:31:47 UTC
I did not try the old driver yet but I was unable to reproduce the problem with
AIGLX disabled.
Comment 11 Michal Suchanek 2006-12-14 10:29:20 UTC
With ati 6.6.3 it is harder to reproduce. Perhaps it happens only when the
server terminates.
Comment 12 Michel Dänzer 2006-12-16 02:46:25 UTC
(In reply to comment #11)
> With ati 6.6.3 it is harder to reproduce.

Can you try isolating the change that made things worse with git-bisect?

(In reply to comment #9)
> I do not use the 7.1 xorg release because OpenGL does not work on Radeon with
that.

What's the problem with that?
Comment 13 Michal Suchanek 2006-12-19 10:28:25 UTC
 (In reply to comment #12)
> (In reply to comment #11)
> > With ati 6.6.3 it is harder to reproduce.
> 
> Can you try isolating the change that made things worse with git-bisect?

Unfortunately I probably won't be able to do that now.

> 
> (In reply to comment #9)
> > I do not use the 7.1 xorg release because OpenGL does not work on Radeon with
> that.
> 
> What's the problem with that?

The normal stuff. The card locks up and the system has to be rebooted to get
anything on the screen again.
Comment 14 Michal Suchanek 2007-01-03 12:21:50 UTC
(In reply to comment #12)
> (In reply to comment #11)
> > With ati 6.6.3 it is harder to reproduce.
> 
> Can you try isolating the change that made things worse with git-bisect?
> 

Was the patch to fix the console on exit already checked in? I tried with some X
server after Dec 20, and I still do get broken console after server exit, even
with the release driver.

Without fixing that it would be quite hard to find the version that also breaks
the conslole while running.
Comment 15 Michel Dänzer 2007-01-04 05:53:59 UTC
(In reply to comment #14)
> 
> Was the patch to fix the console on exit already checked in? 

Which patch are you referring to?
Comment 16 Michal Suchanek 2007-01-04 14:34:37 UTC
(In reply to comment #15)
> (In reply to comment #14)
> > 
> > Was the patch to fix the console on exit already checked in? 
> 
> Which patch are you referring to?

There is not really a patch - the change explained in comment #2.

Comment 17 Michel Dänzer 2007-01-05 03:07:33 UTC
I fixed that regression in
http://gitweb.freedesktop.org/?p=xorg/xserver.git;a=commit;h=729fca33a417ae3dfb180caf0ea8946ef9eee1df
almost a month ago.
Comment 18 Michal Suchanek 2007-01-05 14:34:45 UTC
ok, so this is probably something else. I can see the change reverted in the
tree I have here.

I will try to find a configuration that does restore the console correctly, even
on exit.

iirc it worked with the old X server, even with recent ati driver.
Comment 19 Michal Suchanek 2007-01-07 07:52:14 UTC
Now with the latest ati driver I can no longer reproduce the problem.

There was some fix related to saved state so I guess that's it.
Comment 20 Roland Scheidegger 2007-01-07 09:35:55 UTC
(In reply to comment #19)
> Now with the latest ati driver I can no longer reproduce the problem.
> 
> There was some fix related to saved state so I guess that's it.
If you are refering to 9506f7015a1e442f4ca0bd3bfae555ec7e8a5f37 it shouldn't
make a difference, as this should only affect the register values in use while X
is active, but the driver should restore all values as read initially when
switching to a console, which this commit does not change.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.