Bug 92532 - unused pointer in p11-kit-0.23.1/p11-kit/modules.c
Summary: unused pointer in p11-kit-0.23.1/p11-kit/modules.c
Status: RESOLVED FIXED
Alias: None
Product: p11-glue
Classification: Unclassified
Component: p11-kit (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Stef Walter
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-19 10:48 UTC by Pankaj
Modified: 2015-10-21 06:22 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
p11-kit-0.23.1-module patch (464 bytes, text/plain)
2015-10-19 10:48 UTC, Pankaj
Details
p11-kit-0.23.1-module-004 patch for unused pointer (460 bytes, patch)
2015-10-21 03:20 UTC, Pankaj
Details | Splinter Review

Description Pankaj 2015-10-19 10:48:37 UTC
Created attachment 118976 [details]
p11-kit-0.23.1-module patch

Hi,
it has been reported as "unused pointer" 
char *value = NULL; in file :p11-kit-0.23.1/p11-kit/modules.c:486.

the patch has been attached ,please review it.
=======================================================

diff -Naur a/p11-kit-0.23.1/p11-kit/modules.c b/p11-kit-0.23.1/p11-kit/modules.c
--- a/p11-kit-0.23.1/p11-kit/modules.c  2014-11-12 16:28:50.000000000 +0530
+++ b/p11-kit-0.23.1/p11-kit/modules.c  2015-10-19 15:38:29.345378129 +0530
@@ -483,7 +483,6 @@
 {
        const char *filename = NULL;
        const char *remote = NULL;
-       char *value = NULL;
        CK_RV rv = CKR_OK;
        Module *mod;

@@ -533,7 +532,6 @@
        mod->critical = critical;

 out:
-       free (value);
        return rv;
 }
Comment 1 Stef Walter 2015-10-20 16:12:26 UTC
This looks good. Could you please attach a patch from 'git format-patch -1'?
Comment 2 Pankaj 2015-10-21 03:20:43 UTC
Created attachment 119024 [details] [review]
p11-kit-0.23.1-module-004 patch for unused pointer

Hi ,
The patch has been updated .
please review it.

Thanks!
Comment 3 Stef Walter 2015-10-21 06:22:59 UTC
Thanks. Applied to git master


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.