Created attachment 118976 [details] p11-kit-0.23.1-module patch Hi, it has been reported as "unused pointer" char *value = NULL; in file :p11-kit-0.23.1/p11-kit/modules.c:486. the patch has been attached ,please review it. ======================================================= diff -Naur a/p11-kit-0.23.1/p11-kit/modules.c b/p11-kit-0.23.1/p11-kit/modules.c --- a/p11-kit-0.23.1/p11-kit/modules.c 2014-11-12 16:28:50.000000000 +0530 +++ b/p11-kit-0.23.1/p11-kit/modules.c 2015-10-19 15:38:29.345378129 +0530 @@ -483,7 +483,6 @@ { const char *filename = NULL; const char *remote = NULL; - char *value = NULL; CK_RV rv = CKR_OK; Module *mod; @@ -533,7 +532,6 @@ mod->critical = critical; out: - free (value); return rv; }
This looks good. Could you please attach a patch from 'git format-patch -1'?
Created attachment 119024 [details] [review] p11-kit-0.23.1-module-004 patch for unused pointer Hi , The patch has been updated . please review it. Thanks!
Thanks. Applied to git master
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.