Bug 92788 - [IVB/HSW/BYT/BDW/BSW Bisected ]SynMark2 "OglShMapPcf" cannot run as image validation failed
Summary: [IVB/HSW/BYT/BDW/BSW Bisected ]SynMark2 "OglShMapPcf" cannot run as image val...
Status: VERIFIED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Drivers/DRI/i965 (show other bugs)
Version: unspecified
Hardware: All Linux (All)
: high major
Assignee: Jason Ekstrand
QA Contact: Intel 3D Bugs Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-03 03:42 UTC by ye.tian
Modified: 2015-11-09 11:43 UTC (History)
3 users (show)

See Also:
i915 platform:
i915 features:


Attachments
Xorg.0.log (21.77 KB, text/plain)
2015-11-03 03:42 UTC, ye.tian
Details
UnrealEngine4 Sun Temple demo rendering issue, example 1 (626.79 KB, image/png)
2015-11-04 15:17 UTC, Eero Tamminen
Details
UnrealEngine4 Sun Temple demo rendering issue, example 2 (355.66 KB, image/png)
2015-11-04 15:17 UTC, Eero Tamminen
Details

Description ye.tian 2015-11-03 03:42:02 UTC
Created attachment 119367 [details]
Xorg.0.log

System Environment:       
Platform: IVB/HSW/BYT/BDW/BSW
Mesa:    (master)b639ed2f1b170d1184c6d94c88c826c51ffc8726
Kernel: (drm-intel-nightly)d4f412886ec9694658ab17092c3f70569a0405f9

Bug detailed description:
--------------------------------------------------
SynMark2 "OglShMapPcf" cannot run as image validation failed.
It’s Mesa regression,by bisected, show the first bad mesa commit is 486268b.

commit 486268bdb03a36faf09d84e0458ff49dd1325c40 
Author:     Connor Abbott <cwabbott0@gmail.com>
AuthorDate: Sat Jun 6 13:32:21 2015 -0400
Commit:     Connor Abbott <cwabbott0@gmail.com>
CommitDate: Fri Oct 30 02:19:00 2015 -0400

    i965: always run the post-RA scheduler

    Before, we would only do scheduling after register allocation if we
    spilled, despite the fact that the pre-RA scheduler was only supposed to
    be for register pressure and set the latencies of every instruction to
    1. This meant that unless we spilled, which we rarely do, then we never
    considered instruction latencies at all, and we usually never bothered
    to try and hide texture fetch latency. Although a later commit removes
    the setting the latency to 1 part, we still want to always run the
    post-RA scheduler since it's able to take the false dependencies that
    the register allocator creates into account, and it can be more
    aggressive than the pre-RA scheduler since it doesn't have to worry
    about register pressure at all.


Please see Xrog.

Reproduce steps:
----------------------------
1, xinit& 
2, ./synmark2 OglShMapPcf
Comment 1 ye.tian 2015-11-03 03:47:35 UTC
Update:
mase: latest Master branch:  [af7c98a9c75b17fc8c8ed0989aa732766e5b06d1]
Kernel: latest drm-intel-nightly branch. 4.3.0_drm-intel-nightly_1edf70_20151103
Comment 2 ye.tian 2015-11-03 06:33:58 UTC
Run output info:
----------------------
-- SynMark2 6.0.0 -- 22:18:53 11/03/15 --
Test name: OglShMapPcf
Config name: Default
Validation: Failed - different (2.179 %), different (2.227 %)
OglShMapPcf: Image validation failed - different (2.179 %), different (2.227 %)
Exception caught in OglShMapPcf: Image incorrectly rendered
Comment 3 Eero Tamminen 2015-11-04 15:15:56 UTC
Issue is visible in the ShMapPcf shadows.

I'm seeing similar kind of texturing issue also in UnrealEngine "SunTemple" demo lights and shadows:
  https://wiki.unrealengine.com/Linux_Demos

See attached (partial) screenshots.


On SKL, SynMark2 ShMapPcf renders OK.
Comment 4 Eero Tamminen 2015-11-04 15:17:13 UTC
Created attachment 119403 [details]
UnrealEngine4 Sun Temple demo rendering issue, example 1
Comment 5 Eero Tamminen 2015-11-04 15:17:34 UTC
Created attachment 119404 [details]
UnrealEngine4 Sun Temple demo rendering issue, example 2
Comment 6 Jason Ekstrand 2015-11-07 20:03:29 UTC
I believe that this commit (recently pushed to master) might fix it:

http://cgit.freedesktop.org/mesa/mesa/commit/?id=d43e16b1638cdadc7fcff2007b106e2a559dae7d

Please let me know if it does.
Comment 7 Jason Ekstrand 2015-11-07 20:27:32 UTC
I ran both the synmark case and SunTemple on my Broadwell.  The patch fixes both.
Comment 8 Eero Tamminen 2015-11-09 11:43:38 UTC
Thanks!

I checked with Nightly on HSW & BSW that ShMapPcf and Sun Temple look OK, so I think this can be set as verified.  If QA still sees problem on IVB/BYT/BDW, please re-open.

PS. Bug ID is wrong in the commit.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.