Bug 9280 - minor shell script portability fix
Summary: minor shell script portability fix
Status: RESOLVED FIXED
Alias: None
Product: dbus
Classification: Unclassified
Component: core (show other bugs)
Version: unspecified
Hardware: All NetBSD
: high normal
Assignee: Havoc Pennington
QA Contact: John (J5) Palmieri
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-12-07 13:18 UTC by Dan McMahill
Modified: 2007-10-09 12:50 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
updated patch (1.40 KB, patch)
2007-10-09 05:03 UTC, Simon McVittie
Details | Splinter Review

Description Dan McMahill 2006-12-07 13:18:18 UTC
in tools/run-with-tmp-session-bus.sh revision 1.6, there are two instances of
the following construct:

export FOO=bar

which for better portability should be written as

FOO=bar
export FOO

The lines in question are:

export PATH="$DBUS_TOP_BUILDDIR"/bus:$PATH
## the libtool script found by the path search should already do this, but
export LD_LIBRARY_PATH=$DBUS_TOP_BUILDDIR/dbus/.libs:$LD_LIBRARY_PATH
Comment 1 Simon McVittie 2007-10-09 05:03:43 UTC
Created attachment 11955 [details] [review]
updated patch
Comment 2 Havoc Pennington 2007-10-09 05:58:40 UTC
Looks great, thank you. (feel free to commit)
Comment 3 John (J5) Palmieri 2007-10-09 12:50:33 UTC
Applied to HEAD


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.