Bug 92924 - [regression BXT SKL] piglit.spec.khr_texture_compression_astc.array-gl
Summary: [regression BXT SKL] piglit.spec.khr_texture_compression_astc.array-gl
Status: RESOLVED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Drivers/DRI/i965 (show other bugs)
Version: git
Hardware: x86-64 (AMD64) Linux (All)
: medium major
Assignee: Tapani Pälli
QA Contact: Intel 3D Bugs Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-12 19:08 UTC by Mark Janes
Modified: 2015-11-30 22:30 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:


Attachments

Description Mark Janes 2015-11-12 19:08:19 UTC
mesa f84bc57d7dc02fceb805803131426c791eadeff9 broke this test on bxt and skl:

/tmp/build_root/m32/lib/piglit/bin/khr_compressed_astc-array_gl -auto -fbo

Standard Error

Failed to compile fragment shader: 0:4(1): error: No precision specified in this scope for type `sampler2DArray'

source:
#version 300 es
precision highp float;

uniform sampler2DArray tex;
uniform int index;
in vec2 tex_coord;
out vec4 fragment_color;

void main()
{
    vec4 t = texture(tex, vec3(tex_coord.x, tex_coord.y, index));
    fragment_color = vec4(t.rgb, 1.0);
}


Author:     Iago Toral Quiroga <itoral@igalia.com>
AuthorDate: Tue Nov 10 08:22:07 2015 +0200
Commit:     Tapani Pälli <tapani.palli@intel.com>
CommitDate: Thu Nov 12 09:50:13 2015 +0200

    glsl: Add precision information to ir_variable
    
    We will need this later on when we implement proper support for
    precision qualifiers in the drivers and also to do link time checks for
    uniforms as indicated by the spec.
    
    This patch also adds compile-time checks for variables without precision
    information (currently, Mesa only checks that a default precision is set
    for floats in fragment shaders).
    
    As indicated by Ian, the addition of the precision information to
    ir_variable has been done using a bitfield and pahole to identify an
    available hole so that memory requirements for ir_variable stay the
    same.
Comment 1 Mark Janes 2015-11-12 19:09:04 UTC
assigning to Tapani, since Iago probably doesn't have a skl.
Comment 2 Tapani Pälli 2015-11-12 19:44:02 UTC
test is broken, here's the fix:

http://lists.freedesktop.org/archives/piglit/2015-November/017932.html
Comment 3 Ian Romanick 2015-11-30 22:30:52 UTC
It looks like the piglit change has landed, so I'm closing this as fixed.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.