Created attachment 119909 [details] Be more specific in the case of authentication error When an authentication error occurs SPICE_CLIENT_ERROR_AUTH_NEEDS_PASSWORD or SPICE_CLIENT_ERROR_AUTH_NEEDS_PASSWORD_AND_USERNAME is returned as a channel error. But it can happen that only username is needed when you use e.g. GSSAPI. It would be useful to have SPICE_CLIENT_ERROR_AUTH_NEEDS_USERNAME so that clients don't show authentication prompt which asks for username and password in this case (so it asks just for username). Attached patch adds the error. It would be great if spice-gtk wouldn't ask for this at all and used default principal's name for such situations.
Comment on attachment 119909 [details] Be more specific in the case of authentication error Patch looks good. Could you please git-send-mail it to our mailing list? spice-devel@lists.freedesktop.org
(In reply to Victor Toso from comment #1) > Comment on attachment 119909 [details] > Be more specific in the case of authentication error > > Patch looks good. Could you please git-send-mail it to our mailing list? > spice-devel@lists.freedesktop.org Thanks. I've sent the patch there but unfortunately it was send more times than I wanted (first use of git send-email...).
(In reply to Marek Kasik from comment #2) > Thanks. I've sent the patch there but unfortunately it was send more times > than I wanted (first use of git send-email...). No problem :) http://cgit.freedesktop.org/spice/spice-gtk/commit/?id=fd6cecaaa28705063a67f3543c6e709151de1794 Thanks!
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.