Bug 93009 - [patch] initialize uninitialized variables
Summary: [patch] initialize uninitialized variables
Status: RESOLVED WONTFIX
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/intel (show other bugs)
Version: git
Hardware: Other FreeBSD
: medium normal
Assignee: Chris Wilson
QA Contact: Intel GFX Bugs mailing list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-19 12:01 UTC by Koop Mast
Modified: 2015-11-19 12:11 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
initialize variables (9.32 KB, patch)
2015-11-19 12:01 UTC, Koop Mast 		no flags Details | Splinter Review
Xorg.log without the patch (7.53 KB, text/plain)
2015-11-19 12:02 UTC, Koop Mast 		no flags Details
View All

Description Koop Mast 2015-11-19 12:01:20 UTC 
Created attachment 119931 [details] [review]
initialize variables

Initialize variables where clang reports that they are uninitialized.

FreeBSD uses Clang as the default compiler. Without these patches xorg-server crashes launch or there is graphical corruption.

Tested with 2.99.917, the patch is against the master branch.
Comment 1 Koop Mast 2015-11-19 12:02:11 UTC 
Created attachment 119932 [details]
Xorg.log without the patch
Comment 2 Chris Wilson 2015-11-19 12:11:49 UTC 
If clang is accessing the variables before initializing, setting them to NULL won't make any difference, just silence a false warning from clang.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.