Bug 93122 - [SNB BAT IGT regression] pm_rpm started skipping with CI build 844
Summary: [SNB BAT IGT regression] pm_rpm started skipping with CI build 844
Status: CLOSED FIXED
Alias: None
Product: DRI
Classification: Unclassified
Component: DRM/Intel (show other bugs)
Version: XOrg git
Hardware: Other All
: highest critical
Assignee: Intel GFX Bugs mailing list
QA Contact: Intel GFX Bugs mailing list
URL:
Whiteboard:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2015-11-26 13:35 UTC by Daniel Vetter
Modified: 2016-12-13 09:09 UTC (History)
3 users (show)

See Also:
i915 platform: SNB
i915 features: power/runtime PM


Attachments

Description Daniel Vetter 2015-11-26 13:35:39 UTC
SNB supports rpm, the testcase should not skip. Somehow it started doing that though:

IGT-Version: 1.12-ge10ba6b (x86_64) (Linux: 4.4.0-rc2-gfxbench+ x86_64)
Runtime PM support: 1
PC8 residency support: 0
Test requirement not met in function enable_one_screen, file pm_rpm.c:332:
Test requirement: enable_one_screen_with_type(data, SCREEN_TYPE_ANY)
Subtest basic-pci-d3-state: SKIP (0.104s)

This is a regression, and it means we have a test coverage gap.
Comment 1 Jani Nikula 2015-11-27 11:46:35 UTC
Please attach the dmesg etc. so we can at least have a chance at looking at what type of machine it is.
Comment 2 Daniel Vetter 2015-11-27 13:41:02 UTC
The testcase SKIPs. There isn't anything in dmesg ofc.

For full details please read

http://benchsrv.fi.intel.com/archive/results/CI_IGT_test/CI_DRM_848/snb-dellxps/html/snb-dellxps@CI_DRM_848@1/igt@pm_rpm@basic-pci-d3-state.html

Unfortunately I can't get at a working log any more because CI deletes old logs :(
Comment 4 Daniel Vetter 2016-01-13 12:58:37 UTC
Unassigning since Jani only assigned to me for additional info. I can't repro this on my local SNB, there pm_rpm@basic-rte works perfectly.
Comment 5 Paulo Zanoni 2016-03-08 17:33:28 UTC
Looking at the CI results page, I don't see any SKIPs happening recently, especially for this machine. What I see is that in some cases the test was not run, and I'm not sure if this is a problem.

Can we close this?

As a note, if we skip at enable_one_screen_with_type(ANY), it means that the program didn't find any connected connector for modeset, which could be either a bug or just a machine without real connectors connected.
Comment 6 Chris Wilson 2016-03-08 21:20:15 UTC
(In reply to Paulo Zanoni from comment #5)
> Looking at the CI results page, I don't see any SKIPs happening recently,
> especially for this machine. What I see is that in some cases the test was
> not run, and I'm not sure if this is a problem.
> 
> Can we close this?

It's appeared in CI patch results today on the ml, so it is still definitely a problem.
Comment 7 Jairo Miramontes 2016-03-23 19:32:57 UTC
Running the test ./pm_rpm --run-subtest basic-pci-d3-state is passing on my side on an SNB platform using the following Configuration:


Kernel 4.5.0-nightly

commit 4b39223f6e3bef4dfa678f7239dcd87c38e20e96
Author: Matt Roper <matthew.d.roper@intel.com>
Date:   Mon Mar 21 11:44:01 2016 -0700
    drm-intel-nightly: 2016y-03m-21d-18h-43m-18s UTC integration manifest
--------------------------------------------------------------------------

Hardware Information

Platform: SNB
Motherboard Model: OptiPlex 990
CPU: Core i7-2600 CPU@ 3.40GHz
GPU Card: 2nd Generation Core processor family Integrated graphics controller
Memory ram: 8GB
Hard Drive capacity: 2.00 TB
---------------------------------------------------------------------------
Comment 8 Ileana 2016-04-20 15:34:31 UTC
FWIW, it looks like this test has sporadically inconsistent behavior across all platforms, not sure whether the root cause it's the same though. If someone looks into this further, maybe it's worth considering other cases as well (e.g. dmesg fails on SNB-x220t and occasional skips across all).

http://benchsrv.fi.intel.com/archive/results/CI_IGT_test/igt@pm_rpm@basic-pci-d3-state.html for reference
Comment 9 yann 2016-04-25 10:14:31 UTC
We have seen it only on SNB and APL (but this is expected result at this stage). Can you confirm what are the other impacted platforms as well as attaching more information whenever this bug is also being seen?
Comment 10 dog 2016-07-28 05:36:02 UTC
What's the next step for this bug? It's been open for 3 months with no comment.  Perhaps it's time to close it?  Is the bug still being seen in CI runs?
Comment 11 Chris Wilson 2016-07-28 06:21:06 UTC
The root cause is https://patchwork.freedesktop.org/patch/88669/
Comment 12 Chris Wilson 2016-07-28 06:25:58 UTC
Pretending my analysis is perfect,

commit 12c100bfa5d9103b6c4d43636fee09c31e75605a
Author: Ville Syrjälä <ville.syrjala@linux.intel.com>
Date:   Mon May 23 17:42:48 2016 +0300

    drm/i915: Never fully mask the the EI up rps interrupt on SNB/IVB

and note that we worked around this bug in the meantime by avoiding the looping batch on snb inside igt.
Comment 13 Jari Tahvanainen 2016-12-13 09:09:57 UTC
Closing resolved+fixed with assumption that SKIP is expected behavior for basic-pci-d3-state on SNB. See https://intel-gfx-ci.01.org/CI/igt@pm_rpm@basic-pci-d3-state.html. If assumption is not correct then this bug shall be reopened against IGT component, not kernel.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.