Created attachment 120319 [details]
dmesg

Created attachment 120320 [details]
xorg log

Seems this is because there is no longer a default as there was in the case statement.

If I add a couple of printk sitting on the commit before "bad" I hit the default case during bootup (before I startx).

[    5.030315] ADF: Hit first default, reg_offset = 31
[    5.030406] ADF: Hit second default, reg_offset = 15

diff and full dmesg attached to show timing/position of output.

Created attachment 120337 [details]
debugging diff

Created attachment 120338 [details]
dmesg with debugging output

Of course had I looked at the code rather than just the diff on fdo cgit I wouldn't have needed to bother with printks -

const u32 num_tile_mode_states = 32;
const u32 num_secondary_tile_mode_states = 16;

Ugh never mind, I see that the last slot should already be set to 0 :-(

Where's the delete post button :-)

Created attachment 120343 [details]
removes stray break

OK I think I've found it now.

There's a stray break in the TONGA bit of the new code.

After a quick search I can't find any others.

Updated patch pushed.