Bug 93268 - Invalid memory access in xcb_icccm_get_wm_class_from_reply
Summary: Invalid memory access in xcb_icccm_get_wm_class_from_reply
Status: RESOLVED MOVED
Alias: None
Product: XCB
Classification: Unclassified
Component: Utils (show other bugs)
Version: unspecified
Hardware: All All
: medium normal
Assignee: xcb mailing list dummy
QA Contact: xcb mailing list dummy
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-05 23:20 UTC by jpinon
Modified: 2019-02-16 19:44 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description jpinon 2015-12-05 23:20:58 UTC
I fell in a case where in xcb_icccm_get_wm_class_from_reply, the reply was empty, i.e., in following snippet from icccm.c, len was 0, and reply->length was 0 also.

  int len = xcb_get_property_value_length(prop->_reply);
  if(len < reply->length * 4)
    prop->instance_name[len] = 0;
  else
    prop->instance_name[len-1] = 0;

in this case, prop->instance_name[-1] is set to 0, and the following strlen(prop->instance_name) may access invalid memory.

This may be reproduced under openbox window manager, under which there is this window triggering the bug :

If xwininfo is compiled without icccm :
./xwininfo -tree -root | grep Openbox
     0xe0008b "Openbox": ("" (none))  1x1+-100+-100  +-100+-100

If xwininfo is compiled with icccm :
./xwininfo -tree -root | grep Openbox                                                                          
     0xe0008b "Openbox": ("" "")  1x1+-100+-100  +-100+-100

The second case triggers the Invalid memory access
Comment 1 GitLab Migration User 2019-02-16 19:44:07 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/xorg/lib/libxcb-cursor/issues/1.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.