Bug 9343 - hal-device-manager: [patch] cosmetic issues with dbus-python 0.80
Summary: hal-device-manager: [patch] cosmetic issues with dbus-python 0.80
Status: RESOLVED WONTFIX
Alias: None
Product: hal
Classification: Unclassified
Component: misc (show other bugs)
Version: unspecified
Hardware: All All
: high trivial
Assignee: David Zeuthen (not reading bugmail)
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-12-14 09:08 UTC by Simon McVittie
Modified: 2007-04-04 11:33 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
patch against git HEAD (also for 0.5.8.1) (2.74 KB, patch)
2006-12-14 09:24 UTC, Simon McVittie
Details | Splinter Review

Description Simon McVittie 2006-12-14 09:08:09 UTC
In the upcoming version 0.80 of dbus-python, parameters to D-Bus signal handlers
are D-Bus-specific data types, which subclass the Python built-in types that
were previously used.

Because hal-device-manager displays values differently according to their type
but does not allow for subclasses, this leads to two cosmetic bugs:

 * everything is claimed to be a "strlist"

 * values look ugly and confusing, since the newly unambiguous __repr__ methods
on the D-Bus data types cause them to be displayed as: dbus.Int32(123),
dbus.String(u"abc"), dbus.Array([dbus.String(u"abc")], signature="s")

The (about to be) attached patch addresses this.
Comment 1 Simon McVittie 2006-12-14 09:24:57 UTC
Created attachment 8104 [details] [review]
patch against git HEAD (also for 0.5.8.1)

Also in git+ssh://people.freedesktop.org/~smcv/public_html/git/hal.git
Comment 2 Danny Kukawka 2007-04-04 11:33:26 UTC
hal-device-manager is dropped in > hal v0.5.9


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.