Created attachment 120809 [details]
Redundant check for NULL

Hi,
there is already checked 'module' for NULL at line 
p11-kit/modules.c:2654 .So need to check again for NULL
the respective patch has been attached please review it .
======================================================
diff --git a/p11-kit/modules.c b/p11-kit/modules.c
index 63baeb1..71e1850 100644
--- a/p11-kit/modules.c
+++ b/p11-kit/modules.c
@@ -2673,7 +2673,7 @@ p11_kit_load_initialize_module (const char *module_path,
                        }
                }

-               if (rv == CKR_OK && module) {
+               if (rv == CKR_OK) {
                        *module = unmanaged_for_module_inlock (mod);
                        assert (*module != NULL);
                }

-----------------------------------------------------

Thanks!
Pankaj Sharma