Bug 93596 - xdg-screensaver should call system perl instead of just perl
Summary: xdg-screensaver should call system perl instead of just perl
Status: NEW
Alias: None
Product: Portland
Classification: Unclassified
Component: xdg-utils (show other bugs)
Version: 1.1.0 rc3
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: Portland Bugs
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-05 17:37 UTC by Tim Heaney
Modified: 2016-01-05 18:42 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
patch against current git repo (352 bytes, text/plain)
2016-01-05 17:37 UTC, Tim Heaney
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Heaney 2016-01-05 17:37:54 UTC
Created attachment 120820 [details]
patch against current git repo

I installed an alternate version of Perl higher in my path than the system perl and started getting warnings when I called parole

$ parole foo.mp4
Can't locate Net/DBus.pm in @INC (you may need to install the Net::DBus module) (@INC contains: /home/tim/perl/lib /home/tim/.plenv/versions/5.22.1/lib/perl5/site_perl/5.22.1/x86_64-linux /home/tim/.plenv/versions/5.22.1/lib/perl5/site_perl/5.22.1 /home/tim/.plenv/versions/5.22.1/lib/perl5/5.22.1/x86_64-linux /home/tim/.plenv/versions/5.22.1/lib/perl5/5.22.1 .) at -e line 1.
BEGIN failed--compilation aborted at -e line 1.

After some fussing, I determined that the warning was coming from xdg-screensaver, specifically, the screensaver_gnome_screensaver() function. It calls Perl with just "perl -e" which assumes that whatever perl is highest in the path has the Net::DBus module. I changed line 918 from "perl -e" to "/usr/bin/perl -e" and now all is well.

$ xdg-screensaver --version
xdg-screensaver 1.1.0 rc3

$ lsb_release --description
Description:	Ubuntu 15.10

That's on my system, but the issue still seems to be present. I've attached a patch against the current source.
Comment 1 Rex Dieter 2016-01-05 17:47:58 UTC
I'm tempted to consider this WONTFIX, but I'll let other mantainers chime in if they feel otherwise.
Comment 2 Tim Heaney 2016-01-05 18:42:14 UTC
But why? Isn't this just a sneakier version of

https://bugs.freedesktop.org/show_bug.cgi?id=16642

I guess it's just a warning, not an error, but still. Seems like an easy win.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.