Bug 93601 - Rain and insects are not rendered in Shadow of Mordor with Intel Mesa driver
Summary: Rain and insects are not rendered in Shadow of Mordor with Intel Mesa driver
Status: RESOLVED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Drivers/DRI/i965 (show other bugs)
Version: git
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: Kenneth Graunke
QA Contact: Intel 3D Bugs Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-06 01:01 UTC by Darius Spitznagel
Modified: 2016-01-15 05:51 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
Benchmark how it should look like (247.56 KB, image/jpeg)
2016-01-06 01:01 UTC, Darius Spitznagel
Details

Description Darius Spitznagel 2016-01-06 01:01:38 UTC
Created attachment 120823 [details]
Benchmark how it should look like

Hello devs,

the SoM-Benchmark should show rain and insects flying around a hive.
But they are not visible with latest git master.

I have attached a screenshot where you can see rain and the hive in front of Talon.

The rain should also be visible ingame... there are scenarios with nigth, daylight ... and rainy weather. You know it when Talons cloak is wet, like in the screenshot.

Would be really nice if you could figure this out.
Thanks in advance
Darius
Comment 1 Darius Spitznagel 2016-01-13 20:52:36 UTC
Hello Kenneth,

maybe you didn't know but your commit http://cgit.freedesktop.org/mesa/mesa/patch/?id=c034dbeda8850fe1f3ec0dbdbd73344ace024748 fixed missing rain and insects and some more I wasn't aware of!

The downside is, that the rain rendering eats around 66% (on my system) of the performance compared to without rain.

Luckily SoM has a preferences file (.local/share/feral-interactive/ShadowOfMordor/preferences) where many effects can be en- or disabled!

For example...
<value name="DisableEmitRainCompute" type="integer">1</value>
<value name="DisableSimRainCompute" type="integer">1</value>
...restores my 66% of performance.

GL_ARB_compute_shader support in mesa/i965 is very new. I'm sure it will improve by time.
I'm very happy that SoM renders now how it should:)

Thanks
Comment 2 Kenneth Graunke 2016-01-14 01:04:29 UTC
Oh, really?  Great :)

I didn't see any, even after the patch, but maybe my settings were too low, so rain/insect rendering was disabled.  I'll have to try it again!

I really wanted to put "fixes bugs in bug rendering" in the commit message... :)
Comment 3 Darius Spitznagel 2016-01-14 12:47:57 UTC
To be 100% sure I rechecked.

git checkout 9095847c254be2d55ab188232aa6b84555dbac4e > no rain
git checkout c034dbeda8850fe1f3ec0dbdbd73344ace024748 > with rain

This was tested with kernel 4.3.3 on Intel(R) Core(TM) i7-4770R CPU/Iris Pro 5200.

In both cases I also applied your mordor patch http://cgit.freedesktop.org/~kwg/mesa/commit/?h=mordor&id=980ed880257d24407c4312f24cef1520b51c11f8 before compiling.
Comment 4 Kenneth Graunke 2016-01-15 05:51:24 UTC
Yep, I see it now too - I apparently was using a build without ARB_compute_shader turned on.  Thanks again for the reports and testing!

Now we just need to get it running faster :)


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.