Bug 93889 - Allow building without backend
Summary: Allow building without backend
Status: RESOLVED FIXED
Alias: None
Product: GeoClue
Classification: Unclassified
Component: General (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Geoclue Bugs
QA Contact: Geoclue Bugs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-27 17:41 UTC by Cosimo Cecchi
Modified: 2016-01-28 15:39 UTC (History)
3 users (show)

See Also:
i915 platform:
i915 features:


Attachments
patch (15.98 KB, patch)
2016-01-27 17:43 UTC, Cosimo Cecchi
Details | Splinter Review
Move public-api directory to toplevel (12.30 KB, patch)
2016-01-27 21:43 UTC, Cosimo Cecchi
Details | Splinter Review
Add an option to disable the backend build (4.60 KB, patch)
2016-01-27 21:44 UTC, Cosimo Cecchi
Details | Splinter Review
gclue-locator: remove redundant include (713 bytes, patch)
2016-01-28 13:15 UTC, Cosimo Cecchi
Details | Splinter Review
Move public-api directory to toplevel (13.95 KB, patch)
2016-01-28 13:15 UTC, Cosimo Cecchi
Details | Splinter Review
Add an option to disable the backend build (4.60 KB, patch)
2016-01-28 13:16 UTC, Cosimo Cecchi
Details | Splinter Review

Description Cosimo Cecchi 2016-01-27 17:41:07 UTC
This is convenient to bundle the convenient library in xdg-app bundles.
See attached patch.
Comment 1 Cosimo Cecchi 2016-01-27 17:43:46 UTC
Created attachment 121327 [details] [review]
patch

Add an option to disable the backend build
    
With xdg-app, we will want to bundle the client convenience library with
applications that require GeoClue, without having them ship all the
backend service files, which will be shipped in the core OS.
    
Introduce a --disable-backend build option that implements this policy.
Comment 2 Cosimo Cecchi 2016-01-27 21:43:42 UTC
Created attachment 121331 [details] [review]
Move public-api directory to toplevel

We're about to make the src directory optional; move this at the
toplevel so that libgeoclue can include it directly.
Comment 3 Cosimo Cecchi 2016-01-27 21:44:13 UTC
Created attachment 121332 [details] [review]
Add an option to disable the backend build

With xdg-app, we will want to bundle the client convenience library with
applications that require GeoClue, without having them ship all the
backend service files, which will be shipped in the core OS.
Comment 4 Cosimo Cecchi 2016-01-27 21:44:28 UTC
Split into two separate patches as per Zeeshan's request.
Comment 5 Zeeshan Ali 2016-01-28 10:18:18 UTC
(In reply to Cosimo Cecchi from comment #4)
> Split into two separate patches as per Zeeshan's request.

Thanks. Unfortunately these patches break distcheck.
Comment 6 Cosimo Cecchi 2016-01-28 13:15:00 UTC
Created attachment 121349 [details] [review]
gclue-locator: remove redundant include

This is already included in the header - don't include it again here.
Comment 7 Cosimo Cecchi 2016-01-28 13:15:26 UTC
Created attachment 121350 [details] [review]
Move public-api directory to toplevel

We're about to make the src directory optional; move this at the toplevel so that libgeoclue can include it directly.
Comment 8 Cosimo Cecchi 2016-01-28 13:16:02 UTC
Created attachment 121351 [details] [review]
Add an option to disable the backend build

With xdg-app, we will want to bundle the client convenience library with applications that require GeoClue, without having them ship all the backend service files, which will be shipped in the core OS.

Introduce a --disable-backend build option that implements this policy.
Comment 9 Cosimo Cecchi 2016-01-28 13:16:30 UTC
Fixed distcheck now.
Comment 10 Zeeshan Ali 2016-01-28 15:39:00 UTC
Pushed with some minor changes to git log.

Attachment 121350 [details] pushed as 384e3e0 - Move public-api directory to toplevel


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.