Bug 93928 - Tonga valley regression since drm/amdgpu: split VM mappings into smaller operations (v2)
Summary: Tonga valley regression since drm/amdgpu: split VM mappings into smaller oper...
Status: RESOLVED FIXED
Alias: None
Product: DRI
Classification: Unclassified
Component: DRM/AMDgpu (show other bugs)
Version: DRI git
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: Default DRI bug account
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-29 14:48 UTC by Andy Furniss
Modified: 2016-05-02 22:48 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments
Possible fix (1.26 KB, patch)
2016-01-30 10:06 UTC, Christian König 		no flags Details | Splinter Review
View All

Description Andy Furniss 2016-01-29 14:48:53 UTC 
R8285 agd5f drm-next-4.6-wip

Since below Unigine Valley renders mostly a screen full of colored blocks.

Doesn't affect desktop, Unreal Elemental or xonotic.

In case settings are relevant I run valley ultra quality fullscreen 1920x1080 8xAA

commit 8292e95e64134e8c81ccec25fb702f3c838c2a1e
Author: Christian König <christian.koenig@amd.com>
Date:   Mon Jan 25 14:27:31 2016 +0100

    drm/amdgpu: split VM mappings into smaller operations (v2)
    
    If we can't copy entries from the GTT or fill them with one command split
    up the mapping operation into multiple ones.
    
    v2: agd: rebase on upstream
Comment 1 Nicolai Hähnle 2016-01-29 15:30:15 UTC 
Hi Andy, do you have a screenshot? What version of Mesa are you using? Anything in dmesg?
Comment 2 Christian König 2016-01-29 16:16:16 UTC 
Crap, that looks like I haven't pushed the latest version of that to our server where Alex picket it up. There are numerous bugs in the version of the patch which went upstream.

I'm going to take a look what went wrong as soon as I have time (going to FOSDEM this weekend).
Comment 3 Alex Deucher 2016-01-29 16:20:23 UTC 
I'll drop them from my wip tree for now.
Comment 4 Andy Furniss 2016-01-29 17:11:20 UTC 
(In reply to Alex Deucher from comment #3)
> I'll drop them from my wip tree for now.

OK and have a good time at FOSDEM
Comment 5 Andy Furniss 2016-01-29 17:12:13 UTC 
There was nothing in dmesg.
Comment 6 Christian König 2016-01-30 10:06:22 UTC 
Created attachment 121411 [details] [review]
Possible fix

Please try the attached patch if you have time.

Completely untested (not even compiled), but should do most of the trick.

Need to check in detail when I'm back home.
Comment 7 Andy Furniss 2016-01-30 10:55:06 UTC 
Patch is good, all seems OK so far.

Testing the version of drm-next-4.6-wip that I bisected as Alex has updated and removed the fail commit from latest.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.