Bug 93999 - [BXT/KBL] igt/gem_ctx_create/invalid-pad
Summary: [BXT/KBL] igt/gem_ctx_create/invalid-pad
Status: CLOSED FIXED
Alias: None
Product: DRI
Classification: Unclassified
Component: DRM/Intel (show other bugs)
Version: DRI git
Hardware: Other Linux (All)
: medium normal
Assignee: cprigent
QA Contact: Intel GFX Bugs mailing list
URL: http://patchwork.freedesktop.org/patc...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-04 10:21 UTC by Rami
Modified: 2016-08-04 12:23 UTC (History)
1 user (show)

See Also:
i915 platform: BXT, KBL
i915 features:


Attachments
dmesg (316.63 KB, text/plain)
2016-02-04 10:21 UTC, Rami
no flags Details

Description Rami 2016-02-04 10:21:04 UTC
Created attachment 121512 [details]
dmesg

fail on BXT with last setup:

Setup:
======
Platform: Broxton P A0 Platform
CPU Name : Intel(R) @ 1.2 GHz (family: 6, model: 92, stepping: 8) – 4 cores
SoC : BROXTON-P A0
CRB : Apollo Lake LPDDR3 RVP2B
Reworks : R17, R18, PNP3

Software:
=========
BIOS (IFWI Version): APLK_IFWI_X64_R_2015_44_3_00
KSC : 1.05
Linux distribution: Ubuntu 15.10 64 bits
Kernel: drm-intel-nightly 4.5 rc1 6b1049b
http://cgit.freedesktop.org/drm-intel/
drm: tag libdrm-2.4.66 e342c0f from http://cgit.freedesktop.org/mesa/drm/
mesa: tag mesa-11.0.9  from http://cgit.freedesktop.org/mesa/mesa/
cairo: tag 1.15.2 db8a7f1 from http://cgit.freedesktop.org/cairo
waffle: master bb29b2a from https://github.com/waffle-gl/waffle
xorg-server-macros: master d7acec2 from git://git.freedesktop.org/git/xorg/util/macros
libva: tag libva-1.6.1 cb418f6 from http://cgit.freedesktop.org/libva/
vaapi-intel-driver: tag 1.6.1 2110b3a from http://cgit.freedesktop.org/vaapi/intel-driver
Tools
deqp: tag android-cts-6.0_r2 cf44075 from https://android.googlesource.com/platform/external/deqp
ogles1conform master from https://git-amr-2.devtools.intel.com/gerrit/gitweb?p=otc_gen_graphics-khronos-glconform.git
ogles2-3conform branch gles3-new-skylake f64cf0f from https://git-amr-2.devtools.intel.com/gerrit/gitweb?p=otc_gen_graphics-khronos-glconform.git
intel-gpu-tool: (HEAD, origin/master, origin/HEAD) d63e72f0ad281f295b058a572741b995a5a0f64a from git://git.freedesktop.org/git/xorg/app/intel-gpu-tools 

Steps:
======
./gem_ctx_create --run-subtest invalid-pad

Actual result:
==============
IGT-Version: 1.13-NOT-GIT (x86_64) (Linux: 4.5.0-rc1-no-suspend-ww06+ x86_64)
(gem_ctx_create:1310) CRITICAL: Test assertion failure function __real_main37, file gem_ctx_create.c:65:
(gem_ctx_create:1310) CRITICAL: Failed assertion: drmIoctl(fd, DRM_IOCTL_I915_GEM_CONTEXT_CREATE, &create) < 0 && errno == EINVAL
Stack trace:
  #0 [__igt_fail_assert+0xf1]
  #1 [__real_main37+0x22b]
  #2 [main+0x29]
  #3 [__libc_start_main+0xf0]
  #4 [_start+0x29]
  #5 [<unknown>+0x29]
Subtest invalid-pad failed.
**** DEBUG ****
(gem_ctx_create:1310) DEBUG: Test requirement passed: !(ret != 0 && (errno == ENODEV || errno == EINVAL))
(gem_ctx_create:1310) CRITICAL: Test assertion failure function __real_main37, file gem_ctx_create.c:65:
(gem_ctx_create:1310) CRITICAL: Failed assertion: drmIoctl(fd, DRM_IOCTL_I915_GEM_CONTEXT_CREATE, &create) < 0 && errno == EINVAL
****  END  ****
Subtest invalid-pad: FAIL (0.002s)

Expected result:
================
tests are pass
Comment 1 Chris Wilson 2016-02-05 16:46:46 UTC
http://patchwork.freedesktop.org/patch/72744/
Comment 2 cprigent 2016-02-14 11:38:01 UTC
Also reproduced on KBL. 

Hardware
Platform: KABY LAKE-U
CPU : Intel(R) Core(TM) @ 2.60GHz
MCP : KBL-U G0 2+2 (ou ULT-G0)
QDF : QYQ8
Chipset PCH: SPT-LP C1
CRB : KABY LAKE U DDR3L RVP7 CRB FAB1
Software
BIOS : KBLSE2R1.R00.X015.B01.1511271314
ME FW : 11.5.0.1008
Ksc (EC FW): 1.20
Linux distribution: Ubuntu 15.10 64 bits
Kernel: drm-intel-nightly 4.5.0-rc3_d9bd337 from
http://cgit.freedesktop.org/drm-intel/
commit d9bd337b4b2d46f73005fcdf0e7049e7f8ed5c04
Author: Jani Nikula <jani.nikula@intel.com>
Date: Tue Feb 9 17:43:10 2016 +0200
drm-intel-nightly: 2016y-02m-09d-15h-42m-46s UTC integration manifest
drm: tag libdrm-2.4.66-33-gf884af9
intel-gpu-tool: intel-gpu-tools-1.13-195-g8d441ee

Assigned to me to check the patch
Comment 3 Chris Wilson 2016-02-16 13:18:59 UTC
commit b31e51360e88f8f9831a153cf72d1aced952dffb
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Fri Feb 5 16:45:59 2016 +0000

    drm/i915: Reject invalid-pad for context-destroy and -create ioctls
    
    Unknown parameters, especially structure padding, are expected to invoke
    rejection with -EINVAL.
    
    v2: similar issue exists for context-create
    
    Testcase: igt/gem_ctx_create/invalid-pad
    Testcase: igt/gem_ctx_bad_destroy/invalid-pad
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89602
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93999
    Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
    Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
    Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
    Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
    Link: http://patchwork.freedesktop.org/patch/msgid/1454690759-31201-1-git-send-email-chris@chris-wilson.co.uk
Comment 4 Elio 2016-02-29 20:04:50 UTC
Confirmed, test is passing with following configuration:

Linux distribution: Ubuntu 15.10 64 bits
Kernel drm-intel-nightly 4.5.0-rc5_1a139ea from http://cgit.freedesktop.org/drm-intel/
commit 1a139ead792d8e912aa13d413b9cf59811fde676
Author: Jani Nikula <jani.nikula@intel.com>
Date:   Mon Feb 22 10:48:46 2016 +0200
 drm-intel-nightly: 2016y-02m-22d-08h-48m-06s UTC integration manifest
drm: tag libdrm-2.4.66 9b77443 from http://cgit.freedesktop.org/mesa/drm/
mesa: tag mesa-11.1.1 330aa44from http://cgit.freedesktop.org/mesa/mesa/
cairo: tag 1.15.2 db8a7f1 from http://cgit.freedesktop.org/cairo
waffle: master bb29b2a from https://github.com/waffle-gl/waffle
xorg-server-macros: master d7acec2 from git://git.freedesktop.org/git/xorg/util/macros
libva: tag libva-1.6.1 1f026de from http://cgit.freedesktop.org/libva/
vaapi-intel-driver: tag 1.6.1 f6fe842 from http://cgit.freedesktop.org/vaapi/intel-driverFirmware

Firmware
(APL)DMC 1.06 from https://01.org/linuxgraphics/downloads/broxton-dmc-1.06

Output:
sudo ./gem_ctx_create --run-subtest invalid-pad
IGT-Version: 1.13-gbabcf40 (x86_64) (Linux: 4.5.0-rc5-nightly+ x86_64)
Subtest invalid-pad: SUCCESS (0.000s)
Comment 5 cprigent 2016-08-04 12:23:05 UTC
Also Pass on KBL-U

Platform: KABY LAKE-U
CPU : Intel(R) Core(TM) @ 2.60GHz
MCP : KBL-U G0 2+2
QDF : QYQ8
Chipset PCH: SPT-LP C1
CRB : KABY LAKE U DDR3L RVP7 CRB FAB1

Software
BIOS: 38_07 KBLSE2R1.R00.X038.P07.1606200632 from https://ubit-artifactory-ba.intel.com/artifactory/simple/one-windows-local/Submissions/ifwi/KBL_PURPLE_IFWI_2016_WW26_1_00_HR'16/IFWI-KBL_PURPLE_IFWI_2016_WW26_1_00_HR'16-R.7z
ME FW: 11.5.0.1058
EC FW: 1.19
Ksc (EC FW): 1.20
Linux distribution: Ubuntu 16.04 64 bits
Kernel: 4.7.0 6f87e85 from http://cgit.freedesktop.org/drm-intel/
   commit 6f87e85fa302ffdb4cb9f4cd712691165923c7a2
 Author: Chris Wilson <chris@chris-wilson.co.uk>
  Date:   Mon Aug 1 15:53:41 2016 +0100
  drm-intel-nightly: 2016y-08m-01d-14h-53m-17s UTC integration manifest
drm: libdrm-2.4.70 f19cd3a from git://anongit.freedesktop.org/mesa/drm
mesa: mesa-11.2.2 3a9f628from git://anongit.freedesktop.org/mesa/mesa
cairo: 1.15.2 db8a7f1 from git://anongit.freedesktop.org/cairo
xserver: xorg-server-1.18.0-502 c833c08 from git://git.freedesktop.org/git/xorg/xserver
xf86-video-intel: 2.99.917-688 49daf5d from git://git.freedesktop.org/git/xorg/driver/xf86-video-intel
libva: libva-1.7.0-40 f7e2263 from git://git.freedesktop.org/git/vaapi/libva
vaapi-intel-driver: 1.7.0-64 1cd6795 from git://git.freedesktop.org/git/vaapi/intel-driver
GuC 9.14 from http://rdvivi-hillsboro.jf.intel.com/firmware/kbl_guc_ver9_14.tar.bz2 
DMC 1.01 from: https://01.org/linuxgraphics/downloads/kabylake-dmc-1.01 
Intel-Gpu-Tools 1.15-188 53b4dfd from http://anongit.freedesktop.org/git/xorg/app/intel-gpu-tools.git
Comment 6 cprigent 2016-08-04 12:23:14 UTC
So closed


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.