Bug 94113 - [SKL-Y] DMC 1.23 fails to load after installing GuC 4.3
Summary: [SKL-Y] DMC 1.23 fails to load after installing GuC 4.3
Status: CLOSED WORKSFORME
Alias: None
Product: DRI
Classification: Unclassified
Component: DRM/Intel (show other bugs)
Version: unspecified
Hardware: x86-64 (AMD64) Linux (All)
: highest blocker
Assignee: cprigent
QA Contact: Intel GFX Bugs mailing list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-12 15:24 UTC by cprigent
Modified: 2016-09-19 10:43 UTC (History)
3 users (show)

See Also:
i915 platform: SKL
i915 features: firmware/dmc, firmware/guc, power/runtime PM


Attachments
kern_tests-pass.log (243.74 KB, text/plain)
2016-02-12 15:24 UTC, cprigent
no flags Details
kern_basic-rte-fail.log (905.70 KB, text/plain)
2016-02-12 15:25 UTC, cprigent
no flags Details
kern_basic-pci-d3-state-fails.log (383.24 KB, text/plain)
2016-02-12 15:25 UTC, cprigent
no flags Details
GuC 4.3 with new installation script. (59.16 KB, text/plain)
2016-03-07 23:34 UTC, Rodrigo Vivi
no flags Details

Description cprigent 2016-02-12 15:24:40 UTC
Created attachment 121711 [details]
kern_tests-pass.log

Setup:
-------
Platform: NUC6i3SYH
CPU: Intel(R) Core(TM) i3-6100U CPU @ 2.30GHZ (family 6, model 78, stepping 3)
Motherboard version: H81132-502
GPU: Intel® HD Graphics 520 - Intel Corporation Sky Lake Integrated Graphics (rev 07)
Memory: one 8GB card Kingston KVR21S15D8/8
SSD: Samsung 850 EVO M.2 120 Go
Software
Bios: SYSKLi35.86A.0024.2015.1027.2142
Linux distribution: Ubuntu 15.10 64 bits
Kernel: drm-intel-nightly 4.5.0-rc3 2dc2aec from http://cgit.freedesktop.org/drm-intel
  commit 2dc2aec853ab9d381000663507bdc874028fce0b
  Author: Jani Nikula <jani.nikula@intel.com>
  Date: Wed Feb 10 10:56:42 2016 +0200
  drm-intel-nightly: 2016y-02m-10d-08h-56m-16s UTC integration manifest UTC integration manifest
drm: tag libdrm-2.4.66 e342c0f from http://cgit.freedesktop.org/mesa/drm/
mesa: tag mesa-11.0.8 261daab from http://cgit.freedesktop.org/mesa/mesa/
cairo: tag 1.15.2 db8a7f1 from http://cgit.freedesktop.org/cairo
waffle: master bb29b2a from https://github.com/waffle-gl/waffle
xorg-server-macros: master d7acec2 from git://git.freedesktop.org/git/xorg/util/macros
libva: tag libva-1.6.1 cb418f6 from http://cgit.freedesktop.org/libva/
vaapi-intel-driver: tag 1.6.1 2110b3a from http://cgit.freedesktop.org/vaapi/intel-driver 

GuC: 4.3 from https://01.org/sites/default/files/downloads/intelr-graphics-linux/sklgucver43.tar.bz2

Pre-conditions:
----------------
Prepare same kernel of setup with this patch applied: https://patchwork.freedesktop.org/series/3045/

Steps:
------
1. Boot with kernel without the patch applied
2. Execute IGT pm_rpm tests: basic-pci-d3-state and basic-rte
3. Boot with kernel with patch applied (GuC is loaded)
4. execute same tests

Actual result:
--------------
2. Tests are Pass
4. Tests are Fail:
./pm_rpm --run-subtest basic-pci-d3-state
IGT-Version: 1.13-NOT-GIT (x86_64) (Linux: 4.5.0-rc3-patch-enable-guc+ x86_64)
Runtime PM support: 1
PC8 residency support: 0
(pm_rpm:1488) CRITICAL: Test assertion failure function pci_d3_state_subtest, file pm_rpm.c:1396:
(pm_rpm:1488) CRITICAL: Failed assertion: wait_for_suspended()
Stack trace:
  #0 [__igt_fail_assert+0xf1]
  #1 [main+0x2743]
  #2 [__libc_start_main+0xf0]
  #3 [_start+0x29]
  #4 [<unknown>+0x29]
Subtest basic-pci-d3-state failed.
**** DEBUG ****
(pm_rpm:1488) DEBUG: Test requirement passed: has_runtime_pm
(pm_rpm:1488) CRITICAL: Test assertion failure function pci_d3_state_subtest, file pm_rpm.c:1396:
(pm_rpm:1488) CRITICAL: Failed assertion: wait_for_suspended()
****  END  ****
Subtest basic-pci-d3-state: FAIL (10.036s)

./pm_rpm --run-subtest basic-rte
IGT-Version: 1.13-NOT-GIT (x86_64) (Linux: 4.5.0-rc3-patch-enable-guc+ x86_64)
Runtime PM support: 1
PC8 residency support: 0
(pm_rpm:1163) CRITICAL: Test assertion failure function basic_subtest, file pm_rpm.c:745:
(pm_rpm:1163) CRITICAL: Failed assertion: wait_for_suspended()
Stack trace:
  #0 [__igt_fail_assert+0xf1]
  #1 [main+0x27a0]
  #2 [__libc_start_main+0xf0]
  #3 [_start+0x29]
  #4 [<unknown>+0x29]
Subtest basic-rte failed.
**** DEBUG ****
(pm_rpm:1163) CRITICAL: Test assertion failure function basic_subtest, file pm_rpm.c:745:
(pm_rpm:1163) CRITICAL: Failed assertion: wait_for_suspended()
****  END  ****
Subtest basic-rte: FAIL (10.033s)

Expected results:
-----------------
4. Tests are Pass with GuC loaded
Comment 1 cprigent 2016-02-12 15:25:13 UTC
Created attachment 121712 [details]
kern_basic-rte-fail.log
Comment 2 cprigent 2016-02-12 15:25:35 UTC
Created attachment 121713 [details]
kern_basic-pci-d3-state-fails.log
Comment 3 Yu Dai 2016-02-16 20:58:27 UTC
There is dmc loading issue:
[drm:intel_csr_ucode_init] Loading i915/skl_dmc_ver1.bin
[drm] Refusing to load old Skylake DMC firmware v1.22, please upgrade to v1.23 or later [https://01.org/linuxgraphics/intel-linux-graphics-firmwares].
i915 0000:00:02.0: Failed to load DMC firmware

I will suggest running "update-initramfs -k `uname -r` -u" after installing any firmware package.
Comment 4 cprigent 2016-02-17 10:14:33 UTC
I forgot to add it in section setup that I installed DMC 1.23.
I confirm "update-initramfs -k `uname -r` -u" solves the DMC loading issue, then both tests are pass.
Comment 5 cprigent 2016-02-25 11:17:18 UTC
Looks like same as https://bugs.freedesktop.org/show_bug.cgi?id=94102
Comment 6 Mika Kuoppala 2016-03-02 10:22:57 UTC
(In reply to cprigent from comment #4)
> I forgot to add it in section setup that I installed DMC 1.23.
> I confirm "update-initramfs -k `uname -r` -u" solves the DMC loading issue,
> then both tests are pass.

As firmware loading fails, we disable runtime pm so basic-rte thus failed.
With 1.23 I assume this issue is now fixed?


https://bugs.freedesktop.org/show_bug.cgi?id=94102 seems to be missing skl steppings on firmware loading code, so a separate issue.
Comment 7 cprigent 2016-03-02 10:39:30 UTC
Yes, pm_rpm is Pass when DMC is successfully loaded.
The problem is the DMC does not load anymore after installing GuC, until you use "update-initramfs -k `uname -r` -u".
Comment 8 Rodrigo Vivi 2016-03-07 23:34:02 UTC
Created attachment 122154 [details]
GuC 4.3 with new installation script.

Hi, Could you please test this new installation script and see if this solves your issue?

Please reinstall dmc properly and make sure it is getting load and then test this new script.

Thanks in advance,
Rodrigo.
Comment 9 Olivier Berthier 2016-03-08 11:07:48 UTC
Hi,

The DMC is still correctly loaded after the GuC installation with the new install script.
Comment 10 Rodrigo Vivi 2016-03-14 20:32:05 UTC
Packages available at 01.org has been updated with the new script.
Thanks for the reporting and testing.
Comment 11 maria guadalupe 2016-04-22 17:53:36 UTC
This test is passing under the following configuration 

Software configuration
=======================
Linux distribution: Ubuntu 15.10 64 bits
Kernel: drm-intel-nightly 4.6.0-rc3_d9131d6 from http://cgit.freedesktop.org/drm-intel/
commit d9131d62d18ba94fb3ca019f1156c22b5f4ce23c
Author: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Date:   Fri Apr 15 14:54:26 2016 +0100
drm-intel-nightly: 2016y-04m-15d-13h-53m-44s UTC integration manifestdrm: tag libdrm-2.4.66-33-gf884af9
      libdrm 2.4.67-25 cc9a53f from git://git.freedesktop.org/git/mesa/drm
mesa 11.1.2 7bcd827 from git://git.freedesktop.org/git/mesa/mesa
cairo 1.15.2 db8a7f1 from git://git.freedesktop.org/git/cairo
xorg/xserver 1.18.0-274 8437955 from git://git.freedesktop.org/git/xorg/xserver
xf86-video-intel 2.99.917-634 81029be from git://git.freedesktop.org/git/xorg/driver/xf86-video-intel
vaapi/libva 1.7.0-1 2339d10 from git://git.freedesktop.org/git/vaapi/libva
vaapi/intel-driver 1.7.0-8 2c1bec0 from git://git.freedesktop.org/git/vaapi/intel-driver
intel-gpu-tool 1.14 7bd2ac6 from http://anongit.freedesktop.org/git/xorg/app/intel-gpu-tools.git
rendercheck master 44032a7 from http://anongit.freedesktop.org/git/xorg/app/rendercheck.git

DMC - Ver 1.26 

Steps:
------
run the command :
# ./pm_rpm --run-subtest basic-pci-d3-state

Actual result:
---------------
The result of the test is success

test output
==============
./pm_rpm --run-subtest basic-pci-d3-state
IGT-Version: 1.14-g41a26b5 (x86_64) (Linux: 4.6.0-rc3-nightly+ x86_64)
Runtime PM support: 1
PC8 residency support: 0
Subtest dpms-lpsp: SUCCESS (4.870s)


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.