Bug 94234 - Hachured filling bleeds to whole page
Summary: Hachured filling bleeds to whole page
Status: RESOLVED FIXED
Alias: None
Product: poppler
Classification: Unclassified
Component: cairo backend (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: poppler-bugs
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-21 12:44 UTC by xyzdragon
Modified: 2016-04-02 10:25 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
save mask state and dont extend image mask (1.99 KB, patch)
2016-02-24 06:09 UTC, Jason Crain
Details | Splinter Review

Description xyzdragon 2016-02-21 12:44:25 UTC
See this wrongly filed bug: https://bugzilla.gnome.org/show_bug.cgi?id=761639
Comment 1 Jason Crain 2016-02-24 06:09:34 UTC
Created attachment 121935 [details] [review]
save mask state and dont extend image mask

This patch stops the pattern from covering the whole page by not setting CAIRO_EXTEND_PAD.

Fixes part of the pattern from not rendering by saving and restoring the mask in tilingPatternFill.
Comment 2 xyzdragon 2016-02-26 00:22:57 UTC
@Jason: Thanks. I applied the patch to the latest git master and tried it with 
pdftocairo -png convolutionFFT2D.pdf
It works :)
With evince it doesn't work out of the hood. ldd $(which evince) doesn't list libpoppler... maybe it's statically linked
I also tested with pdftocairo without the patch where it doesn't work. Just for comparison.
Comment 3 Carlos Garcia Campos 2016-04-02 10:25:21 UTC
Pushed, thanks!


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.