Bug 94309 - [PATCH] Fix -Werror build for clang and FreeBSD
Summary: [PATCH] Fix -Werror build for clang and FreeBSD
Alias: None
Product: Telepathy
Classification: Unclassified
Component: logger (show other bugs)
Version: git master
Hardware: Other FreeBSD
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
Depends on:
Reported: 2016-02-26 14:24 UTC by Ting-Wei Lan
Modified: 2019-12-03 19:32 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Fix -Werror build for clang and FreeBSD (4.44 KB, patch)
2016-02-26 14:29 UTC, Ting-Wei Lan
Details | Splinter Review

Description Ting-Wei Lan 2016-02-26 14:24:43 UTC
Please see the attached patch. It fixes build failure on FreeBSD with clang when -Werror is enabled.
Comment 1 Ting-Wei Lan 2016-02-26 14:29:01 UTC
Created attachment 121985 [details] [review]
Fix -Werror build for clang and FreeBSD

Replace -D_POSIX_SOURCE with -D_POSIX_C_SOURCE=200809L because the
former macro limits POSIX standard version to 1003.1-1988 on FreeBSD,
which causes atoll function to be unavailable.

-Wtautological-constant-out-of-range-compare is ignored in a
g_return_val_if_fail because the warning cannot be avoided.

Self assignments are removed to prevent warnings.
Comment 2 Ting-Wei Lan 2016-07-16 16:22:28 UTC
Ping ... It is annoying to see -Werror enabled without getting warnings fixed.
Comment 3 GitLab Migration User 2019-12-03 19:32:36 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/telepathy/telepathy-logger/issues/43.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.