Bug 94322 - ext_framebuffer_object.getteximage-formats init-by-rendering broken
Summary: ext_framebuffer_object.getteximage-formats init-by-rendering broken
Status: CLOSED FIXED
Alias: None
Product: piglit
Classification: Unclassified
Component: tests (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Brian Paul
QA Contact: Piglit Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-27 22:55 UTC by Mark Janes
Modified: 2016-02-29 23:29 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments

Description Mark Janes 2016-02-27 22:55:52 UTC 
piglit 91cb2b2b207fea75f0f9b3f9fbeba6b1a7517f0e seems to have unintentionally triggered failures in the init-by-rendering test:

/tmp/build_root/m64/lib/piglit/bin/getteximage-formats init-by-rendering -auto -fbo

Standard Error

Unknown test set: init-by-rendering

Based on the commit message, it looks to me like this was accidental:

---------------------------
91cb2b2b207fea75f0f9b3f9fbeba6b1a7517f0e
Author:     Brian Paul <brianp@vmware.com>
getteximage-formats: pass argc, not 1, to fbo_formats_init() call

Now we can specify the format group on the command line and have it
actually work.
---------------------------
Comment 1 Brian Paul 2016-02-29 15:32:35 UTC 
Hmm, the way fbo_formats_init() is written, it's impossible to pass both a pixel format set name (like "GL_EXT_texture_sRGB") and a test option (like "init-by-rendering") in getteximage-formats.

I'll have to do some refactoring in fbo-formats.h   I'll post a patch soon.
Comment 2 Brian Paul 2016-02-29 22:20:37 UTC 
Fixed with commit 99439d36c0ba90d039335659164ac8d89618f440

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.