In cmd_buffer_emit_depth_stencil it is using image->depth_surface.offset but only image->offset gets updated during vkBindImageMemory.
I bumped into this because I was lazily using a single allocation for both the depth buffer and the color buffer in this project here:
https://github.com/bpeel/finvenkisto/tree/vulkan (the vulkan branch of it)
The depth buffer ends up overlapping with the color buffer and it makes some funky effects. If I change cmd_buffer_emit_depth_stencil to use image->offset instead then it works, but I don't know if that's the correct solution.
No that's the right fix, we missed that. Thanks, patch pushed.