Bug 94458 - dEQP-GLES3.functional.state_query.fbo.framebuffer_attachment_x_size_initial fails
Summary: dEQP-GLES3.functional.state_query.fbo.framebuffer_attachment_x_size_initial f...
Status: RESOLVED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Drivers/DRI/i965 (show other bugs)
Version: git
Hardware: Other All
: medium normal
Assignee: Kenneth Graunke
QA Contact: Intel 3D Bugs Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: i965-deqp
  Show dependency treegraph
 
Reported: 2016-03-09 02:01 UTC by Kenneth Graunke
Modified: 2016-03-10 19:29 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Graunke 2016-03-09 02:01:58 UTC
dEQP-GLES3.functional.state_query.fbo.framebuffer_attachment_x_size_initial queries GL_FRAMEBUFFER_ATTACHMENT_DEPTH_SIZE on the window system depth buffer, and expects to get a proper value (16, 24, 32); we are incorrectly returning 0.

intel_alloc_private_renderbuffer_storage does:

   rb->_BaseFormat = _mesa_base_fbo_format(ctx, internalFormat);

Here, internalFormat is GL_DEPTH_COMPONENT.  _mesa_base_fbo_format only returns GL_DEPTH_COMPONENT in desktop GL.  In ES, it returns 0.

So, we don't get a proper rb->_BaseFormat set, and this makes the query fail.
Comment 1 Kenneth Graunke 2016-03-09 04:19:19 UTC
I'm testing a patch for this.  I think we can just do _mesa_get_format_base_format() instead.
Comment 2 Kenneth Graunke 2016-03-09 04:51:24 UTC
Patch on mailing list (no piglit regressions, fixes the deqp test):
https://lists.freedesktop.org/archives/mesa-dev/2016-March/109464.html
Comment 3 Kenneth Graunke 2016-03-10 19:29:04 UTC
commit 9ea00c6f6b2924befe41f6ef55244e6aa20c702a
Author: Kenneth Graunke <kenneth@whitecape.org>
Date:   Tue Mar 8 20:00:06 2016 -0800

    i965: Set a proper _BaseFormat for window system renderbuffers in ES.


bug/show.html.tmpl processed on Feb 24, 2017 at 01:42:09.
(provided by the Example extension).