Created attachment 122370 [details] dmesg Regression: ----------- Yes, the subtests were pass with the kernel drm-intel-nightly 4.5.0-rc7_dd7b012 and intel-gpu-tools-1.14-26-g174a06b Setup: ------ Hardware Platform: KABY LAKE-U CPU : Intel(R) Core(TM) @ 2.60GHz MCP : KBL-U G0 2+2 (ou ULT-G0) QDF : QYQ8 Chipset PCH: SPT-LP C1 CRB : KABY LAKE U DDR3L RVP7 CRB FAB1 Software BIOS : KBLSE2R1.R00.X015.B01.1511271314 ME FW : 11.5.0.1008 Ksc (EC FW): 1.20 Linux distribution: Ubuntu 15.10 64 bits Kernel drm-intel-nightly 4.5.0-fc881eb from http://cgit.freedesktop.org/drm-intel/ commit fc881ebd9c3c26919c7d1113f8bf7014e1a05563 Author: Daniel Vetter <daniel.vetter@ffwll.ch> Date: Tue Mar 15 14:11:45 2016 +0100 drm-intel-nightly: 2016y-03m-15d-13h-10m-41s UTC integration manifest drm: libdrm-2.4.67-7-g49041c3 cairo: 1.15.2 db8a7f1 intel-gpu-tool: intel-gpu-tools-1.14-62-g8f6ed9e Steps: ------ # ./gem_reset_stats --r ban-blt Actual result: -------------- The test fail. Same thing for the subtests : ban-blt ban-bsd ban-default ban-render ban-vebox Expected result: ---------------- Subtests are Pass Program output: --------------- IGT-Version: 1.14-NOT-GIT (x86_64) (Linux: 4.5.0-nightly+ x86_64) retrying for ban (9) (gem_reset_stats:1195) CRITICAL: Test assertion failure function test_ban, file gem_reset_stats.c:368: (gem_reset_stats:1195) CRITICAL: Failed assertion: rs_bad.batch_pending == pending_count (gem_reset_stats:1195) CRITICAL: error: 1 != 2 Stack trace: #0 [__igt_fail_assert+0xf1] #1 [__real_main773+0x18da] #2 [main+0x29] #3 [__libc_start_main+0xf0] #4 [_start+0x29] #5 [<unknown>+0x29] Subtest ban-bsd failed. **** DEBUG **** (gem_reset_stats:1195) drmtest-DEBUG: Test requirement passed: fd >= 0 (gem_reset_stats:1195) drmtest-DEBUG: Test requirement passed: fd >= 0 (gem_reset_stats:1195) drmtest-DEBUG: Test requirement passed: fd >= 0 (gem_reset_stats:1195) ioctl-wrappers-DEBUG: Test requirement passed: gem_has_ring(fd, ring) (gem_reset_stats:1195) ioctl-wrappers-DEBUG: Test requirement passed: has_ban_period (gem_reset_stats:1195) igt-gt-DEBUG: Test requirement passed: has_gpu_reset(fd) (gem_reset_stats:1195) igt-gt-DEBUG: Test requirement passed: ctx == 0 || ring == I915_EXEC_RENDER (gem_reset_stats:1195) ioctl-wrappers-DEBUG: Test requirement passed: gem_has_ring(fd, ring) (gem_reset_stats:1195) ioctl-wrappers-DEBUG: Test requirement passed: has_ban_period (gem_reset_stats:1195) igt-gt-DEBUG: Test requirement passed: has_gpu_reset(fd) (gem_reset_stats:1195) igt-gt-DEBUG: Test requirement passed: ctx == 0 || ring == I915_EXEC_RENDER (gem_reset_stats:1195) INFO: retrying for ban (9) (gem_reset_stats:1195) ioctl-wrappers-DEBUG: Test requirement passed: gem_has_ring(fd, ring) (gem_reset_stats:1195) ioctl-wrappers-DEBUG: Test requirement passed: has_ban_period (gem_reset_stats:1195) igt-gt-DEBUG: Test requirement passed: has_gpu_reset(fd) (gem_reset_stats:1195) igt-gt-DEBUG: Test requirement passed: ctx == 0 || ring == I915_EXEC_RENDER (gem_reset_stats:1195) CRITICAL: Test assertion failure function test_ban, file gem_reset_stats.c:368: (gem_reset_stats:1195) CRITICAL: Failed assertion: rs_bad.batch_pending == pending_count (gem_reset_stats:1195) CRITICAL: error: 1 != 2 **** END **** Subtest ban-bsd: FAIL (14.339s)
Created attachment 122549 [details] bsw-gem_reset_stats-ban-output ban- subtests are also failing on BSW Hardware: Motherboard: Aspire XC-704 cpu model name : Intel(R) Pentium(R) CPU N3700 @ 1.60GHz cpu model : 76 cpu family : 6 Graphic card: Device 22b1 (rev 21) Software: Bios: R01-A2 kernel nightly 4.5 10e913a from https://cgit.freedesktop.org/cgit/?url=drm-intel/ commit 10e913a48ca36790da9b58bed8729598ea79ebdb Author: Imre Deak <imre.deak@intel.com> Date: Thu Mar 17 15:23:17 2016 +0200 drm-intel-nightly: 2016y-03m-17d-13h-22m-41s UTC integration manifest cairo 1.15.2 db8a7f1 from git://anongit.freedesktop.org/cairo libdrm-2.4.67-7 49041c3 from git://anongit.freedesktop.org/mesa/drm IGT 1.14 8f6ed9e from http://anongit.freedesktop.org/git/xorg/app/intel-gpu-tools.git
Created attachment 122550 [details] BSW-gem_reset_stats_kern.log
The following tests fail on BXT-P with the next configuration test cases ================================ gem_reset_stats@ban-vebox gem_reset_stats@ban-default gem_reset_stats@ban-bsd gem_reset_stats@ban-render gem_reset_stats@ban-blt Software information ================================ Kernel version : 4.6.0-rc4-drm-intel-nightly-ww17-commit-1e81bac+ Linux distribution : Ubuntu 15.10 Architecture : 64-bit Bios revision : 129.10 KSC revision : 1.6 Hardware information ================================ Platform : BXT-P Motherboard model : Broxton P Motherboard type : NOTEBOOK Hand Held Motherboard manufacturer : Intel Corp. CPU family : Other CPU information : 06/5c GPU Card : Intel Corporation Device 5a84 (rev 03) (prog-if 00 [VGA controller]) Memory ram : 8 GB Maximum memory ram allowed : 16 GB Graphic stack information ================================ --> Component : drm url : http://cgit.freedesktop.org/mesa/drm tag : libdrm-2.4.67-26-g739b888 commit : 739b888 author : Nicolas Dechesne <nicolas.dechesne@linaro.org> age : 2 weeks ago --> Component : mesa url : http://cgit.freedesktop.org/mesa/mesa tag : mesa-11.1.2 commit : 7bcd827 author : Emil Velikov <emil.velikov@collabora.com> age : 3 months ago --> Component : xf86-video-intel url : http://cgit.freedesktop.org/xorg/driver/xf86-video-intel tag : 2.99.917-640-gbca4e0e commit : bca4e0e author : Chris Wilson <chris@chris-wilson.co.uk> age : 2 days ago --> Component : libva url : http://cgit.freedesktop.org/libva/ tag : libva-1.7.0-1-g2339d10 commit : 2339d10 author : Xiang Haihao <haihao.xiang@intel.com> age : 6 weeks ago --> Component : vaapi (intel-driver) url : http://cgit.freedesktop.org/vaapi/intel-driver tag : 1.7.0-8-g2c1bec0 commit : 2c1bec0 author : peng.chen <peng.c.chen@intel.com> age : 3 weeks ago --> Component : cairo url : http://cgit.freedesktop.org/cairo tag : 1.15.2 commit : db8a7f1 author : Bryce Harrington <bryce@osg.samsung.com> age : 5 months ago --> Component : xserver url : http://cgit.freedesktop.org/xorg/xserver tag : xorg-server-1.18.0-291-g16e4bce commit : 16e4bce author : Simon Thum <simon.thum@gmx.de> age : 2 weeks ago --> Component : intel-gpu-tools url : http://cgit.freedesktop.org/xorg/app/intel-gpu-tools tag : intel-gpu-tools-1.14-212-g1e9a3ac commit : 1e9a3ac author : Chris Wilson <chris@chris-wilson.co.uk> age : 3 days ago kernel information ================================ commit 1e81bacf1f7fdbdf83f46b55389713fa13cb1256 Author: Chris Wilson <chris@chris-wilson.co.uk> Date: Sun Apr 24 11:36:51 2016 +0100 drm-intel-nightly: 2016y-04m-24d-10h-36m-11s UTC integration manifest Kernel version : 4.6.0-rc4 Architecture : source amd64 all Homepage : http://www.kernel.org/
Increasing priority due to current platform experience impact
Created attachment 123702 [details] kbl-gem_reset_stats-kern.log Following subcases are fail on KBL-U: igt@gem_reset_stats@ban-blt igt@gem_reset_stats@ban-bsd igt@gem_reset_stats@ban-ctx-render igt@gem_reset_stats@ban-default igt@gem_reset_stats@ban-render igt@gem_reset_stats@ban-vebox Attached: kbl-output-gem_reset_stats and kbl-gem_reset_stats-kern.log Hardware Platform: KABY LAKE-U CPU : Intel(R) Core(TM) @ 2.60GHz MCP : KBL-U G0 2+2 (ou ULT-G0) QDF : QYQ8 Chipset PCH: SPT-LP C1 CRB : KABY LAKE U DDR3L RVP7 CRB FAB1 Software BIOS : KBLSE2R1.R00.X015.B01.1511271314 ME FW : 11.5.0.1008 Ksc (EC FW): 1.20 Linux distribution: Ubuntu 16.04 64 bits kernel drm-intel-nightly 4.6.0-rc7 61f856f from http://cgit.freedesktop.org/drm-intel/ commit 61f856faa1e6ff9dddad214be1e372e8aacfc0f4 Author: Ville Syrjälä <ville.syrjala@linux.intel.com> Date: Mon May 9 19:24:21 2016 +0300 drm-intel-nightly: 2016y-05m-09d-16h-24m-01s UTC integration manifest libdrm-2.4.68 fc09c5a from git://anongit.freedesktop.org/mesa/drm cairo: 1.15.2 db8a7f1 from git://anongit.freedesktop.org/cairo IGT 1.14 cc24755 from http://anongit.freedesktop.org/git/xorg/app/intel-gpu-tools.git
Created attachment 123703 [details] kbl-output-gem_reset_stats
commit e075a32f515becef66dc849f5eca47409ccf5473 Author: Chris Wilson <chris@chris-wilson.co.uk> Date: Fri May 13 11:57:22 2016 +0100 drm/i915: Stop automatically retiring requests after a GPU hang Following a GPU hang, we break out of the request loop in order to unlock the struct_mutex for use by the GPU reset. However, if we retire all the requests at that moment, we cannot identify the guilty request after performing the reset. v2: Not automatically retiring requests forces us to recheck for available ringspace. Fixes: f4457ae71fd6 ("drm/i915: Prevent leaking of -EIO from i915_wait_request()") Testcase: igt/gem_reset_stats/ban-* Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Cc: Daniel Vetter <daniel.vetter@ffwll.ch> Cc: Mika Kuoppala <mika.kuoppala@intel.com> Tested-by: Mika Kuoppala <mika.kuoppala@intel.com> Reviewed-by: Mika Kuoppala <mika.kuoppala@intel.com> Link: http://patchwork.freedesktop.org/patch/msgid/1463137042-9669-4-git-send-email-chris@chris-wilson.co.uk and commit e380239dc838f1e8a2ebcc9ddac556e3842ea195 Author: Chris Wilson <chris@chris-wilson.co.uk> Date: Fri May 13 10:30:05 2016 +0100 igt/gem_reset_stats: Fix pending batch count for bans Since 9ba9af2ea4 ("lib: Skip execution in gem_has_ring()"), we no longer do a double execbuf for each hang, as the gem_require_ring() check now does a dummy execution that does not contribuee to the pending batch count. Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Tests are now skip. Hardware Platform: KABY LAKE-U CPU : Intel(R) Core(TM) @ 2.60GHz MCP : KBL-U G0 2+2 (ou ULT-G0) QDF : QYQ8 Chipset PCH: SPT-LP C1 CRB : KABY LAKE U DDR3L RVP7 CRB FAB1 Software BIOS : KBLSE2R1.R00.X015.B01.1511271314 ME FW : 11.5.0.1008 Ksc (EC FW): 1.20 Linux distribution: Ubuntu 16.04 64 bits kernel drm-intel-nightly 4.6.0 d381724 from http://cgit.freedesktop.org/drm-intel/ commit d3817246ca053dd3e7ea8017db4a74707f8195a2 Author: Jani Nikula <jani.nikula@intel.com> Date: Mon May 16 15:14:24 2016 +0300 drm-intel-nightly: 2016y-05m-16d-12h-14m-04s UTC integration manifest drm: libdrm-2.4.68 7aab852 from git://anongit.freedesktop.org/mesa/drm mesa: mesa-11.1.2 7bcd827 from git://anongit.freedesktop.org/mesa/mesa cairo: 1.15.2 db8a7f1 from git://anongit.freedesktop.org/cairo intel-gpu-tools-1.14 b88bce4 from http://anongit.freedesktop.org/git/xorg/app/intel-gpu-tools.git Priority decreased to medium. Let's confirm the result on APL and BSW before closing it.
(In reply to cprigent from comment #8) > Tests are now skip. These should not be skips. Presumably an earlier fail prevented the test running?
This issue is not appearing with the following configuration on BSW ++ Kernel version : 4.6.0-drm-intel-nightly-ww23-commit-fb023a2+ ++ Linux distribution : Ubuntu 16.04 LTS ++ Architecture : 64-bit ++ Mesa version : Mesa 11.2.2 ++ xf86-video-intel version : 2.99.917 ++ Xorg-Xserver version : 1.18.3 ++ DRM version : 2.4.68 ++ VAAPI version : Intel i965 driver for Intel(R) CherryView - 1.7.0 ++ Cairo version : 1.15.2 ++ Intel GPU Tools version : Tag [intel-gpu-tools-1.14-348-g303b380] / Commit [303b380] ++ Kernel driver in use : i915 ++ Hardware acceleration : ++ Bios revision : 0.33 ++ KSC revision : 0.16 |=== Hardware information ===| ++ Platform : ++ Motherboard model : 10G9000NUS ++ Motherboard type : BRASWELL Desktop ++ Motherboard manufacturer : LENOVO ++ CPU family : Pentium ++ CPU information : Intel(R) Pentium(R) CPU N3700 @ 1.60GHz ++ GPU Card : Intel Corporation Device 22b1 (rev 21) (prog-if 00 [VGA controller]) ++ Memory ram : 8 GB ++ Maximum memory ram allowed : 8 GB ++ Display resolution : ++ CPU's number : 4 ++ Hard drive capacity : 120 GB Graphic stack configuration --> Component : drm url : http://cgit.freedesktop.org/mesa/drm tag : libdrm-2.4.68 commit : fc09c5a author : Kenneth Graunke <kenneth@whitecape.org> age : 5 weeks ago --> Component : mesa url : http://cgit.freedesktop.org/mesa/mesa tag : mesa-11.2.2 commit : 3a9f628 author : Emil Velikov <emil.velikov@collabora.com> age : 3 weeks ago --> Component : xf86-video-intel url : http://cgit.freedesktop.org/xorg/driver/xf86-video-intel tag : 2.99.917 commit : baec802 author : Chris Wilson <chris@chris-wilson.co.uk> age : 1 year 5 months ago --> Component : libva url : http://cgit.freedesktop.org/libva/ tag : libva-1.7.0 commit : 85ca8a2 author : Xiang Haihao <haihao.xiang@intel.com> age : 3 months ago --> Component : vaapi (intel-driver) url : http://cgit.freedesktop.org/vaapi/intel-driver tag : 1.7.0 commit : ee45497 author : Xiang Haihao <haihao.xiang@intel.com> age : 3 months ago --> Component : cairo url : http://cgit.freedesktop.org/cairo tag : 1.15.2 commit : db8a7f1 author : Bryce Harrington <bryce@osg.samsung.com> age : 6 months ago --> Component : xserver url : http://cgit.freedesktop.org/xorg/xserver tag : xorg-server-1.18.3 commit : 9454cd5 author : Adam Jackson <ajax@redhat.com> age : 8 weeks ago --> Component : intel-gpu-tools url : http://cgit.freedesktop.org/xorg/app/intel-gpu-tools tag : intel-gpu-tools-1.14-348-g303b380 commit : 303b380 author : Matt Roper <matthew.d.roper@intel.com> age : 5 days ago
(In reply to Chris Wilson from comment #7) > commit e075a32f515becef66dc849f5eca47409ccf5473 > Author: Chris Wilson <chris@chris-wilson.co.uk> > Date: Fri May 13 11:57:22 2016 +0100 > > drm/i915: Stop automatically retiring requests after a GPU hang > > Following a GPU hang, we break out of the request loop in order to > unlock the struct_mutex for use by the GPU reset. However, if we retire > all the requests at that moment, we cannot identify the guilty request > after performing the reset. > > v2: Not automatically retiring requests forces us to recheck for > available ringspace. > > Fixes: f4457ae71fd6 ("drm/i915: Prevent leaking of -EIO from > i915_wait_request()") > Testcase: igt/gem_reset_stats/ban-* > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch> > Cc: Mika Kuoppala <mika.kuoppala@intel.com> > Tested-by: Mika Kuoppala <mika.kuoppala@intel.com> > Reviewed-by: Mika Kuoppala <mika.kuoppala@intel.com> > Link: > http://patchwork.freedesktop.org/patch/msgid/1463137042-9669-4-git-send- > email-chris@chris-wilson.co.uk > > and > > commit e380239dc838f1e8a2ebcc9ddac556e3842ea195 > Author: Chris Wilson <chris@chris-wilson.co.uk> > Date: Fri May 13 10:30:05 2016 +0100 > > igt/gem_reset_stats: Fix pending batch count for bans > > Since 9ba9af2ea4 ("lib: Skip execution in gem_has_ring()"), we no longer > do a double execbuf for each hang, as the gem_require_ring() check now > does a dummy execution that does not contribuee to the pending batch > count. > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Hi Chris : after do a checkout in the commit e075a32f515becef66dc849f5eca47409ccf5473 (drm-intel-nightly) i get the following issue when i trying to apply the patch form http://patchwork.freedesktop.org/patch/msgid/1463137042-9669-4-git-send-email-chris@chris-wilson.co.uk $: patch -p1 <CI-4-4-drm-i915-Stop-automatically-retiring-requests-after-a-GPU-hang.patch patching file drivers/gpu/drm/i915/i915_gem.c Reversed (or previously applied) patch detected! Assume -R? [n] -R Apply anyway? [n] y Hunk #1 FAILED at 1462. Hunk #2 FAILED at 1519. 2 out of 2 hunks FAILED -- saving rejects to file drivers/gpu/drm/i915/i915_gem.c.rej patching file drivers/gpu/drm/i915/intel_ringbuffer.c do you have any recommendation here ? thanks in advanced
No patching should be needed. For verification use latest intel-gpu-tools and drm-intel-nightly.
Pass on APL. Subtest ban-default: SUCCESS (108.932s) Subtest ban-ctx-default: SKIP (0.002s) Subtest ban-render: SUCCESS (25.235s) Subtest ban-ctx-render: SUCCESS (131.813s) Subtest ban-bsd: SUCCESS (17.199s) Subtest ban-ctx-bsd: SKIP (0.000s) Subtest ban-bsd1: SKIP (0.001s) Subtest ban-ctx-bsd1: SKIP (0.000s) Subtest ban-bsd2: SKIP (0.001s) Subtest ban-ctx-bsd2: SKIP (0.000s) Subtest ban-blt: SUCCESS (24.436s) Subtest ban-ctx-blt: SKIP (0.000s) Subtest ban-vebox: SUCCESS (17.095s) Subtest ban-ctx-vebox: SKIP (0.000s) I remove it from summary and "i915 platform" field. Platform: APL system CPU Name : Intel(R) Genuine Processor @ 1.1 GHz (family: 6, model: 12, stepping: 9) 4 cores QDF : Q6HE SoC : B1 CRB : Apollo Lake DDR3L RVP1A FAB2 Reworks : R19, R20 Software Bios: 144_B10 APLK_B0_IFWI_X64_R_2016_06_27_0956_SPI_RVP1.bin from \\gar\ec\proj\ba\CCG\APL BIOS\External\BIOS_Release\Daily\v144_10_2016_WW27.1\IFWI\IFWI_RVP1_Release\IFWI KSC: 1.15 Linux distribution: Ubuntu 16.04 64 bits Kernel: drm-intel-nightly 4.7.0-rc5 2fe5da8 from http://cgit.freedesktop.org/drm-intel/ commit 2fe5da8adcbe5a34830b98c63878eea756e977a2 Author: Chris Wilson <chris@chris-wilson.co.uk> Date: Sat Jul 2 19:32:50 2016 +0100 drm-intel-nightly: 2016y-07m-02d-18h-31m-39s UTC integration manifest drm: libdrm-2.4.68-11 7996a87 from git://anongit.freedesktop.org/mesa/drm mesa: mesa-11.2.2 3a9f628from git://anongit.freedesktop.org/mesa/mesa cairo: 1.15.2 db8a7f1 from git://anongit.freedesktop.org/cairo server: xorg-server-1.18.0-443 3762edd from git://git.freedesktop.org/git/xorg/xserver xf86-video-intel: 2.99.917-674 9154dff from git://git.freedesktop.org/git/xorg/driver/xf86-video-intel libva: libva-1.7.0-26 c36971c from git://git.freedesktop.org/git/vaapi/libva vaapi-intel-driver: 1.7.0-53 bcde10d from git://git.freedesktop.org/git/vaapi/intel-driver GuC 8.7 DMC 1.07 from https://01.org/linuxgraphics/downloads/broxton-dmc-1.07 Intel-Gpu-Tools 1.15-87 376b813 from http://anongit.freedesktop.org/git/xorg/app/intel-gpu-tools.git Let's check on the other platforms before closing it.
passed as well on KBL as well using the below configuration, probably we can close the bug now? igt@gem_reset_stats@ban-blt pass igt@gem_reset_stats@ban-bsd skip igt@gem_reset_stats@ban-ctx-render pass igt@gem_reset_stats@ban-default pass igt@gem_reset_stats@ban-render pass igt@gem_reset_stats@ban-vebox pass igt@gem_reset_stats@ban-bsd2 skip igt@gem_reset_stats@ban-bsd1 skip igt@gem_reset_stats@ban-ctx-bsd2 skip igt@gem_reset_stats@ban-ctx-bsd1 skip igt@gem_reset_stats@ban-ctx-default skip igt@gem_reset_stats@ban-ctx-vebox skip igt@gem_reset_stats@ban-ctx-blt skip igt@gem_reset_stats@ban-ctx-render pass igt@gem_reset_stats@ban-ctx-bsd skip Software information ============================================ Kernel version : 4.7.0-rc6-drm-intel-nightly-ww29-commit-a207bd7+ Linux distribution : Ubuntu 16.04 LTS Architecture : 64-bit bottom >> xf86-video-intel version : 2.99.917 Xorg-Xserver version : 1.18.3 DRM version : 2.4.70 Cairo version : 1.15.2 Intel GPU Tools version : Tag [intel-gpu-tools-1.15-140-ge3abb20] / Commit [e3abb20] Kernel driver in use : i915 Hardware acceleration : Bios revision : 38.7 KSC revision : 1.20 Hardware information ============================================ Platform : KBL (RVP7) Motherboard model : Kabylake Client platform Motherboard type : Skylake U DDR3L RVP7 Laptop Motherboard manufacturer : Intel Corporation CPU family : Other CPU information : Genuine Intel(R) CPU 0000 @ 2.60GHz GPU Card : Intel Corporation Device 5916 (prog-if 00 [VGA controller]) Memory ram : 4 GB Maximum memory ram allowed : 16 GB Display resolution : CPU's number : 4 Hard drive Capacity : 80.0 GB Firmwares information ============================================ DMC fw loaded : yes DMC version : 1.1 GUC version wanted : 9.14 GUC version found : 9.14
So closed
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.