Bug 94639 - build: Run configure script from builddir rather than srcdir
Summary: build: Run configure script from builddir rather than srcdir
Status: RESOLVED FIXED
Alias: None
Product: libmbim
Classification: Unclassified
Component: General (show other bugs)
Version: unspecified
Hardware: All All
: medium normal
Assignee: Aleksander Morgado
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-20 18:01 UTC by Philip Withnall
Modified: 2016-03-21 10:53 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
build: Run configure script from builddir rather than srcdir (1.11 KB, patch)
2016-03-20 18:01 UTC, Philip Withnall
Details | Splinter Review

Description Philip Withnall 2016-03-20 18:01:51 UTC
Trivial patch attached.
Comment 1 Philip Withnall 2016-03-20 18:01:52 UTC
Created attachment 122449 [details] [review]
build: Run configure script from builddir rather than srcdir

If building from a clean git clone with builddir ≠ srcdir, the configure
script is (correctly) generated in builddir by autoconf. Execute it from
there, rather than from the srcdir, so that all the configure products
(Makefiles, etc.) are generated in the builddir.
Comment 2 Aleksander Morgado 2016-03-21 09:47:35 UTC
Thanks! I also ported the fix to libqmi and ModemManager, which had the same issue.
Comment 3 Philip Withnall 2016-03-21 10:34:14 UTC
(In reply to Aleksander Morgado from comment #2)
> Thanks! I also ported the fix to libqmi and ModemManager, which had the same
> issue.

Ta. I had opened bug #94640 about libqmi, so I guess that could be closed now.
Comment 4 Aleksander Morgado 2016-03-21 10:53:04 UTC
(In reply to Philip Withnall from comment #3)
> (In reply to Aleksander Morgado from comment #2)
> > Thanks! I also ported the fix to libqmi and ModemManager, which had the same
> > issue.
> 
> Ta. I had opened bug #94640 about libqmi, so I guess that could be closed
> now.

Ah! sorry for that, didn't realize.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.