Created attachment 122460 [details] [review]
build: Fix autogen.sh when run with builddir ≠ srcdir

When run from outside the srcdir, autogen.sh was failing because various
of the tools it calls expect to be called from within srcdir.

Comment on attachment 122460 [details] [review]
build: Fix autogen.sh when run with builddir ≠ srcdir

Review of attachment 122460 [details] [review]:
-----------------------------------------------------------------

::: autogen.sh
@@ -6,4 @@
>  
>  srcdir=`dirname $0`
>  test -z "$srcdir" && srcdir=.
> -mkdir -p m4

So we are removing this? Are you sure it doesn't cause any issues?

(In reply to Zeeshan Ali from comment #2)
> Comment on attachment 122460 [details] [review] [review]
> build: Fix autogen.sh when run with builddir ≠ srcdir
> 
> Review of attachment 122460 [details] [review] [review]:
> -----------------------------------------------------------------
> 
> ::: autogen.sh
> @@ -6,4 @@
> >  
> >  srcdir=`dirname $0`
> >  test -z "$srcdir" && srcdir=.
> > -mkdir -p m4
> 
> So we are removing this? Are you sure it doesn't cause any issues?

It was a workaround for an automake bug which existed in versions prior to 1.11.0 (https://lists.gnu.org/archive/html/bug-automake/2012-03/msg00046.html). I don’t think it’s necessary any more.

The standard GNOME autogen.sh template is used by a number of projects without problems, and it doesn’t have the `mkdir` call.

https://wiki.gnome.org/Projects/GnomeCommon/Migration#autogen.sh

Pushed the patch with a very minor fix to shortlog.

(In reply to Philip Withnall from comment #3)
> (In reply to Zeeshan Ali from comment #2)
> > Comment on attachment 122460 [details] [review] [review] [review]
> > build: Fix autogen.sh when run with builddir ≠ srcdir
> > 
> > Review of attachment 122460 [details] [review] [review] [review]:
> > -----------------------------------------------------------------
> > 
> > ::: autogen.sh
> > @@ -6,4 @@
> > >  
> > >  srcdir=`dirname $0`
> > >  test -z "$srcdir" && srcdir=.
> > > -mkdir -p m4
> > 
> > So we are removing this? Are you sure it doesn't cause any issues?
> 
> It was a workaround for an automake bug which existed in versions prior to
> 1.11.0
> (https://lists.gnu.org/archive/html/bug-automake/2012-03/msg00046.html). I
> don’t think it’s necessary any more.
> 
> The standard GNOME autogen.sh template is used by a number of projects
> without problems, and it doesn’t have the `mkdir` call.
> 
> https://wiki.gnome.org/Projects/GnomeCommon/Migration#autogen.sh

Ah ok, thanks! I just thought I should make sure that it wasn't removed by mistake. :)