Bug 95159 - Cannot build EGL without x11 headers after interop patchset
Summary: Cannot build EGL without x11 headers after interop patchset
Status: RESOLVED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: EGL (show other bugs)
Version: git
Hardware: ARM Linux (All)
: medium normal
Assignee: mesa-dev
QA Contact: mesa-dev
URL:
Whiteboard:
Keywords:
: 95504 (view as bug list)
Depends on:
Blocks:
 
Reported: 2016-04-26 21:36 UTC by Youry
Modified: 2016-05-25 12:59 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
Patch (2.59 KB, patch)
2016-04-26 21:37 UTC, Youry
Details | Splinter Review
glx: Fix build broken by 4e2c9a04354b6b133845b8b93c0c5d34261a91d0 (1.04 KB, patch)
2016-05-22 13:52 UTC, Dieter Nützel
Details | Splinter Review

Description Youry 2016-04-26 21:36:05 UTC
patch in attachment...
Comment 1 Youry 2016-04-26 21:37:51 UTC
Created attachment 123283 [details] [review]
Patch
Comment 2 Ian Romanick 2016-04-27 08:27:58 UTC
Please send patches to the mesa-dev mailing list using 'git send-email'.  Otherwise they are likely to go unnoticed.
Comment 3 Mark Janes 2016-05-20 13:52:24 UTC
*** Bug 95504 has been marked as a duplicate of this bug. ***
Comment 4 Dieter Nützel 2016-05-22 13:29:44 UTC
https://bugs.freedesktop.org/attachment.cgi?id=123283

The committed patch introduce 'new' compilation error, here.

make[3]: Entering directory '/opt/mesa/src/glx'
  CC       glxcmds.lo
glxcmds.c:2699:1: error: no previous prototype for 'MesaGLInteropGLXQueryDeviceInfo' [-Werror=missing-prototypes]
 MesaGLInteropGLXQueryDeviceInfo(Display *dpy, GLXContext context,
 ^
glxcmds.c:2723:1: error: no previous prototype for 'MesaGLInteropGLXExportObject' [-Werror=missing-prototypes]
 MesaGLInteropGLXExportObject(Display *dpy, GLXContext context,
 ^
cc1: some warnings being treated as errors
Makefile:845: recipe for target 'glxcmds.lo' failed
make[3]: *** [glxcmds.lo] Error 1
make[3]: Leaving directory '/opt/mesa/src/glx'
Makefile:865: recipe for target 'all-recursive' failed
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory '/opt/mesa/src/glx'
Makefile:684: recipe for target 'all-recursive' failed
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory '/opt/mesa/src'
Makefile:631: recipe for target 'all-recursive' failed
make: *** [all-recursive] Error 1

git revert 4e2c9a0

let Mesa build, again.
Comment 5 Dieter Nützel 2016-05-22 13:52:01 UTC
Created attachment 123964 [details] [review]
glx: Fix build broken by 4e2c9a04354b6b133845b8b93c0c5d34261a91d0

Attached patch from

Tom Stellard, idea from
Mark Janes

fixed it here finally, too.
Comment 6 Rob Herring 2016-05-23 14:58:55 UTC
This is still broken on Android builds.
Comment 7 Emil Velikov 2016-05-23 15:54:27 UTC
I've got alternative solution that I'm rebasing atm. Keep an eye open for a dozen or so patches that brings some sense into the GL/CL interop header/implementation.
Comment 8 Emil Velikov 2016-05-25 12:59:07 UTC
Pretty sure that the issue should be resolved with the patches that landed yesterday. Please give it a test and reopen if it's still a problem.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.